Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4466 closed defect (fixed)

CCmpTerritoryManager::IsTerritoryBlinking could crash in non-visual replay mode.

Reported by: leper Owned by: leper
Priority: Should Have Milestone: Alpha 22
Component: Core engine Keywords:
Cc: Patch:

Description

CCmpTerritoryManager::IsTerritoryBlinking uses m_Territory without checking whether it is set, or actually calculating it like most other functions do (and afterwards checking whether it is set).

Change History (4)

comment:2 by elexis, 7 years ago

Component: UI & Simulation → Core engine
Keywords: simple removed
Milestone: Backlog → Work In Progress

(Removing the keyword so others don't find this as a false positive when looking for tasks)

comment:3 by leper, 7 years ago

Owner: set to leper
Resolution: → fixed
Status: new → closed

In 19343:

Ensure m_Territory in cmpTerriotryManager.IsTerritoryBlinking. Fixes #4466.

Patch By: Sandarac
Differential Revision: ​https://code.wildfiregames.com/D261

comment:4 by leper, 7 years ago

Milestone: Work In Progress → Alpha 22
Note: See TracTickets for help on using tickets.