Opened 7 years ago

Closed 7 years ago

#4557 closed defect (fixed)

Selection broken in Atlas

Reported by: Stan Owned by: elexis
Priority: Release Blocker Milestone: Alpha 22
Component: Atlas editor Keywords:
Cc: Patch: ​Phab:D452

Description

After the latest change for the double click, it seems selection, is completely broken in Atlas.

To reproduce, I opened atlas, put three civ centers, and tried to select one, it select the three each time.

If I recruit villagers, and ask them to construct a house, clicking on either the villager, or the house will select the civ center.

If I delete the civ centers and try to select anything I get this error: 

<!DOCTYPE html>
<meta charset="utf-8">
<title>Pyrogenesis Log</title>
<style>body { background: #eee; color: black; font-family: sans-serif; } p { background: white; margin: 3px 0 3px 0; } .error { color: red; } .warning { color: blue; }</style>
<h2>0 A.D. (0.0.22) Main log (warnings and errors only)</h2>
<p class="error">ERROR: JavaScript error: gui/session/input.js line 1011
TypeError: GetEntityState(...) is null
  handleInputAfterGui@gui/session/input.js:1011:25</p>

Change History (8)

comment:1 by elexis, 7 years ago

Cc: causative added

Can reproduce on linux. Thanks for the report.

​https://code.wildfiregames.com/D326

comment:2 by elexis, 7 years ago

Patch: → Phab:D452

comment:3 by elexis, 7 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 19589:

Fix atlas clicking following rP19444 / D326 by adding the missing clicks property to the wxWidgets SDL event construction.

Differential Revision: ​https://code.wildfiregames.com/D452
Fixes #4557
Patch By: causative

comment:4 by elexis, 7 years ago

Component: UI & Simulation → Atlas editor

comment:5 by Stan, 7 years ago

Resolution: fixed
Status: closed → reopened

Still broken for me on windows. If I click on a single units, it selects all the units around it. It causes trouble when trying to select building after having selecting units too.

comment:6 by elexis, 7 years ago

I guess it's still running with the old binary

comment:7 by elexis, 7 years ago

Test again with r19744 or later please

comment:8 by Stan, 7 years ago

Cc: causative removed
Resolution: → fixed
Status: reopened → closed

Ah sorry I forgot to build atlas. I reverted my update workspaces.bat.

Note: See TracTickets for help on using tickets.