Opened 7 years ago
Closed 7 years ago
#4572 closed defect (fixed)
Athen civic center can't research town / city phase of other civs
| Reported by: | elexis | Owned by: | fatherbushido |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 22 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description
When capturing a building, the player can research all technologies there which can be researched in the buildings of that civ too.
Hence players of every civ can research the town / city phase at captured civic center too - unless that civic center is from Athens.
The reason for this must be the civ specific phase tech only Athens have.
(This must be true vice versa for Athen capturing other CCs, but seems slightly less unexpected as one can then research only at Athen CCs).
(Not sure how easy it is to address this, might be a won't fix. Mostly written the ticket for future reference)
Attachments (2)
Change History (5)
comment:1 by , 7 years ago
by , 7 years ago
| Attachment: | patch1.diff added |
|---|
by , 7 years ago
| Attachment: | patch2.diff added |
|---|
comment:2 by , 7 years ago
| Milestone: | Backlog → Alpha 22 |
|---|
If it's easy addressable, we shouldn't leave it as is. It might be somewhat expected if Athens can't research the phase at any other CC, but it is unexpected if non-Athens can research the phase at any other CC except the one of Athens.
patch2.diff is what I had in mind, but wasn't sure in advance whether that icon would be shown but only disabled. But that isn't the case, it's hidden when I tested it.
The icon is removed because ProductionQueue.prototype.GetTechnologiesList removes the tech (// Remove any technologies that can't be researched by this civ) which someone has implemented in r18027 / #3899.
The patch is complete because those are all buildings where we can research phase techs.
So consider it accepted and reviewed. Thanks for the patch!
Well I looked at it. Trying to use "replaces" thing in all that part of the code would be a mess and out of scope. Moreover all is already handle with the (civ) requirements thing. So it's mainly a desgin choice now. Depending on what you want, I suggested three diffs: