Opened 7 years ago

Closed 7 years ago

#4602 closed defect (fixed)

Petra: Errors in transportPlan

Reported by: Sandarac Owned by: mimo
Priority: Must Have Milestone: Alpha 22
Component: AI Keywords:
Cc: mimo Patch:

Description

The attached r19694 replay resulted in this error at around turn 10850, and it continued after: 

ERROR: JavaScript error: simulation/ai/petra/transportPlan.js line 299 TypeError: newPos is undefined
m.TransportPlan.prototype.onBoarding/<@simulation/ai/petra/transportPlan.js:299:1
m.EntityCollection.prototype.forEach@simulation/ai/common-api/entitycollection.js:140:3
m.TransportPlan.prototype.onBoarding@simulation/ai/petra/transportPlan.js:249:2
m.TransportPlan.prototype.update@simulation/ai/petra/transportPlan.js:237:3
m.NavalManager.prototype.update@simulation/ai/petra/navalManager.js:737:19
m.HQ.prototype.update@simulation/ai/petra/headquarters.js:2282:2
m.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:125:3
m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:71:2

I'm not sure if adding a simple check if newPos is undefined will be enough.

Attachments (2)

commands.txt​ (212.5 KB ) - added by Sandarac 7 years ago.
ticket4602.patch​ (801 bytes ) - added by mimo 7 years ago.

Download all attachments as: .zip

Change History (5)

by Sandarac, 7 years ago

Attachment: commands.txt​ added

by mimo, 7 years ago

Attachment: ticket4602.patch​ added

comment:1 by mimo, 7 years ago

due to rP19655. Fixed by the attached patch, I'll commit it if you validate it (here is fine, no need to go to phab for that one)

comment:2 by Sandarac, 7 years ago

Okay thank you mimo, when rerunning the replay non-visually, this error didn't occur anymore.

comment:3 by mimo, 7 years ago

Owner: set to mimo
Resolution: → fixed
Status: new → closed

In 19696:

fix a ai error following r19655, fixes #4602

Note: See TracTickets for help on using tickets.