Opened 7 years ago
Closed 6 years ago
#4651 closed defect (fixed)
Error when loading "Snowflake Searocks" map with one player
Reported by: | Sandarac | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 23 |
Component: | Maps | Keywords: | |
Cc: | elexis, bb | Patch: |
Description
When trying to load the random map "Snowflake Searocks" (with any map size) with only one player, an error occurs, the map fails to load, and the game returns to the main menu:
ERROR: JavaScript error: maps/random/snowflake_searocks.js line 1526 TypeError: IslandX is undefined @maps/random/snowflake_searocks.js:1526:3 ERROR: CMapGeneratorWorker::Run: Failed to load RMS 'maps/random/snowflake_searocks.js'
Change History (2)
comment:1 by , 7 years ago
Milestone: | Backlog → Work In Progress |
---|---|
Priority: | Should Have → Nice to Have |
comment:2 by , 6 years ago
Milestone: | Work In Progress → Alpha 23 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fixed by r20308
Note:
See TracTickets
for help on using tickets.
and the code is absolutely terrible.
The mapgen code is copied about for each mapsize and for each player count.
I've removed the duplication but didn't finish: https://github.com/elexis1/0ad/commit/6ef2588689b9536cf209da384fb21f564870e11d