Ranged aura still applied even when garrisoned

[elexis]

Retardado has reported that sometimes Hero auras are even applied to units if the hero is garrisoned and if that aura is a ranged aura.

Replay the attached r19835 replay to reproduce.

[elexis]

Notice the bug occurs upon the first garrison, but later it doesn't.

[fatherbushido]

Confirmed. Already in a21. It's wrong as after the aura source is garrisoned, the affected unit can go at the other side of the map with still the bonus applied (edit: which leads to an exploit).

[fatherbushido]

We could call a this.Clean() on garrison. But it's weird that it's not already handle by OnRangeUpdate.

edit: For the active query, when the source of the query is garrisoned, the RangeUpdate message is not sent (we would expect that all current queried entities are in msg.removed). So, imo, it seems it's in perhaps manager that it should be fixed. But I wouldn't do too much expectation on what RangeManager is expected or not expected to do.

[fatherbushido]

Attached patch actually updates the queries when the source of an active query is (put) out of world. (rfc)

(for the said problem, build a fortress, an hero (bouddica for example), a champion, garrison the hero, and check for example the capture stat).

[Stan]

Shouldn't be on Phab ? No offense just asking

[fatherbushido]

Because it s a bit wrong

[elexis]

Not a release blocker, but the genie is out of the bottle.

[elexis]

From the meeting today:

(19:19:45) elexis: #4658 looks like it needs an update, so might have to be pushed while fatherbushido is N/A and hope that players dont find out about the garrison ranged aura bug
(19:20:57) Itms: Push #4658

[bb]

In 20845:

Don't early return but update the active query when having no position or when outOfWorld

Based on Patch By: fatherbushido
Patch By: temple
Differential Revision: ​https://code.wildfiregames.com/D1219
Differential Revision: ​https://code.wildfiregames.com/D704
fixes #4658

[Stan]

Moving to the correct milestone.