#4669 closed defect (fixed)
Communicate field diminishing returns to the player
Reported by: | Imarok | Owned by: | Happy Concepts |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 24 |
Component: | UI – In-game | Keywords: | simple |
Cc: | Krinkle | Patch: | Phab:D1803 |
Description
We should somewhere hint the player that for fields every additional gatherer has a decreased gather rate (90% for each). This value is set in DiminishingReturns in the ResourceSupply component.
This could be done by adding a hint to the field's tooltip.
Attachments (1)
Change History (15)
comment:1 by , 5 years ago
Component: | UI & Simulation → In-game UI |
---|
comment:2 by , 5 years ago
Greetz, can I get added to the contrib group on Phabricator to submit patches, please?
I added the following italic to the field tooltip:
Harvest vegetables for food. Max gatherers: 5. Diminishing Returns reduces the rate of additional gatherers.
comment:3 by , 5 years ago
Hi, you do not have to be in contributor group to upload the patch. To the tooltip: I would rephrase it. There is no need to inform players which component is setting the value.
comment:4 by , 5 years ago
Thanks, I agree in principle about the UX. Any tips for how does l10n process go here?
comment:5 by , 5 years ago
Milestone: | Backlog → Work In Progress |
---|---|
Owner: | set to |
comment:6 by , 5 years ago
Keywords: | simple removed |
---|---|
Milestone: | Work In Progress → Alpha 24 |
So it will be nice to remove the hardcoded maximum limit but in the meantime let me say hello as a newcomer and offer this patch.
Up to 5 units may harvest vegetables for food from each field (but at reduced efficiency).
comment:7 by , 5 years ago
Welcome!
Please upload the patch at http://code.wildfiregames.com/ (see also wiki:Phabricator). At least that is much less neglected than trac. In fact I see you have added 100% context already, that's recommended for Phabricator. I see that you use a string change, I'm sure Nescio would have feedback for that.
I wonder though if Imarok didn't have a generic tooltip in mind, one that displays the current efficiency for the field based on the number of workers.
tooltips.js
contains the functions displayed in the tooltip.
The main problem with adding new generic tooltips is that they usually need some more information accessed through GetEntityState
from GUIInterface.js
. Here: the current gather rate per unit. Not sure if more verbosity will be better, for example also passing the information how much slower it will be when adding another unit. Should avoid crowding.
I guess what the player really wants to know is the formula, such as 10% less rate for every worker added, rather than seeing the current number, manipulating the workercount and trying to reverse the formula.
comment:8 by , 5 years ago
Thanks for the info. As I'm really new to the codebase, it may take me awhile to get up to speed. So I thought I might start small with beginner ticket like this one.
Even if Imarok wasn't suggesting a new feature with 4669, I like your thinking. There are several other places where showing players the stacked numbers would be w00t. What is the armor of my skirmisher atop the wall next to my hero's aura hmmm ...
If the ticket really means "hint" as in "don't actually, explicitly tell the player in the tooltip" then I missed.
Otherwise please accept my humble first patch on this UI defect and let's get moving on since I see tons of other tickets.
Actually, since my playtest could not verify that the gather multiplier was even being applied for multiple gatherers, I plan to open a new ticket in that regard and look forward to maybe getting it done for A24 if I can rally some help playtesting it.
comment:9 by , 5 years ago
Keywords: | Beginner added |
---|---|
Milestone: | Alpha 24 → Work In Progress |
Patch: | → Phab:D1803 |
Patch submitted (shortened for space consideration per feedback tks elexis). Play-tested OK with Gaul and Athens. Plan to file a new ticket about
DiminishingReturns
to verify that the modifier is being applied properly.
comment:10 by , 5 years ago
Keywords: | simple added; Beginner removed |
---|
comment:12 by , 5 years ago
Cc: | added |
---|
comment:13 by , 5 years ago
Milestone: | Work In Progress |
---|---|
Resolution: | → fixed |
Status: | new → closed |
comment:14 by , 5 years ago
Milestone: | → Alpha 24 |
---|
Move tickets to
In-game UI
asUI & Simulation
got some sub components.