#476 closed task (fixed)
Use JS_New for ScriptInterface::CallConstructor
| Reported by: | Philip Taylor | Owned by: | |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 3 |
| Component: | Core engine | Keywords: | |
| Cc: | Patch: |
Description
The new JS_New function looks like it does what ScriptInterface::CallConstructor attempts to emulate. We should update to a SpiderMonkey version that includes that function, and then use it (and make sure it doesn't change the behaviour in a way that breaks anything).
Change History (7)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
It's not worthwhile upgrading just for this - better to wait for some new features or important bugfixes so we have to upgrade anyway. (That'll probably be several months, at least.)
I don't think it's necessary to stick with a stable version of SpiderMonkey - it's trivial to recompile the binaries for Windows, and it'll automatically recompile on Linux / OS X, and any bugs or unexpected changes should be caught by our automated tests, so upgrading is pretty cheap and we can do it whenever it seems useful enough.
comment:5 by , 14 years ago
| Milestone: | → Backlog |
|---|
comment:6 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [8638]) Fix #476 (Use JS_New for ScriptInterface::CallConstructor)
comment:7 by , 13 years ago
| Milestone: | Backlog → Alpha 3 |
|---|
Does this mean you want to update to another SpiderMonkey version relatively soonish or just that you want to remember to update to a version supporting this some time in the future? I'm just asking since it would be nice to have sorted out a relatively stable version before the Alpha (by relatively stable I mean that we won't change it too soon again). I'm not sure how important it is, but it would at least be nice to hear your thoughts on it.