undefined property args.endZ

[mimo]

on r20453 with the attached replay, we get WARNING: JavaScript warning: maps/random/rmgen/gaia_terrain.js line 365 reference to undefined property args.endZ

[elexis]

Thanks for the report, it was a typo in ​https://trac.wildfiregames.com/changeset/20429#file11

With this command we can find all properties of all rivermap calls and can observe that there are no other typos:

# test for typos in all propreties
grep -R 'paintRiver({' -A11 --no-filename | grep '"'  | awk '{$1=$1;print}' | sort | uniq

# test for x/z typos
grep -R 'paintRiver({' -A11 --no-filename | grep '"'  | awk '{$1=$1;print}' | sort | grep startZ | wc -l

So concluding that it was the only typo.

[elexis]

In 20456:

Fix typo in rP20429, fixes #4851.

[elexis]

In 20465:

Fix some unintended obliteration in rP20420.

In the Edge Seas variant, fix a wrong horizontal/vertical negation and the direction of the riversize randomization.
Fix the wrong river location translation in that variant in r20429, refs #4851.
Prevent resource collisions on Unknown maps by adding back the large territory marking (after the small territory marking prior to the terrain generation).
Slightly improve river painting performance by not generating the meandering of the second shoreline if that is outside of the map boundary.