Opened 14 years ago

Closed 14 years ago

Last modified 8 years ago

#538 closed defect (fixed)

Atlas has wrong icon in Start menu

Reported by: Philip Taylor Owned by:
Priority: Nice to Have Milestone:
Component: Non-game systems Keywords: simple
Cc: Patch:

Description

See source/tools/dist/0ad.nsi (NSIS installer script). It adds the map editor to the Start menu, and attempts to use AtlasUI.dll's icon, but that file has no icon. We need to somehow get it to use the right icon (currently found in binaries/data/tools/atlas/icons/ScenarioEditor.ico), either by associating that icon with the DLL or by using that icon by itself.

Attachments (1)

nsi.patch​ (879 bytes ) - added by fcxSanya 14 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by fcxSanya, 14 years ago

How about simple changing of this line: 

CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Map editor.lnk" 
"$INSTDIR\binaries\system\pyrogenesis.exe" 
"-editor" "$INSTDIR\binaries\system\AtlasUI.dll"

to: 

CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Map editor.lnk" 
"$INSTDIR\binaries\system\pyrogenesis.exe" 
"-editor" "$INSTDIR\binaries\data\tools\atlas\icons\ScenarioEditor.ico"

in source/tools/dist/0ad.nsi?

It looks working properly.

by fcxSanya, 14 years ago

Attachment: nsi.patch​ added

comment:2 by fcxSanya, 14 years ago

Keywords: review added

comment:3 by Philip Taylor, 14 years ago

Hmm, I must have thought it'd be more complicated than that, but if that works then it's good - thanks :-)

comment:4 by philip, 14 years ago

Resolution: → fixed
Status: new → closed

(In [8016]) Fix #538 (Atlas has wrong icon in Start menu)

comment:5 by (none), 14 years ago

Milestone: Unclassified

Milestone Unclassified deleted

comment:6 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.