Ticket #538 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Atlas has wrong icon in Start menu

Reported by: Philip Owned by:
Priority: Nice to Have Milestone:
Component: Non-game systems Keywords: simple, review
Cc:

Description

See source/tools/dist/0ad.nsi (NSIS installer script). It adds the map editor to the Start menu, and attempts to use AtlasUI.dll's icon, but that file has no icon. We need to somehow get it to use the right icon (currently found in binaries/data/tools/atlas/icons/ScenarioEditor.ico), either by associating that icon with the DLL or by using that icon by itself.

Attachments

nsi.patch​ (879 bytes) - added by fcxSanya 3 years ago.

Change History

comment:1 Changed 3 years ago by fcxSanya

How about simple changing of this line: 

CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Map editor.lnk" 
"$INSTDIR\binaries\system\pyrogenesis.exe" 
"-editor" "$INSTDIR\binaries\system\AtlasUI.dll"

to: 

CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Map editor.lnk" 
"$INSTDIR\binaries\system\pyrogenesis.exe" 
"-editor" "$INSTDIR\binaries\data\tools\atlas\icons\ScenarioEditor.ico"

in source/tools/dist/0ad.nsi?

It looks working properly.

Changed 3 years ago by fcxSanya

comment:2 Changed 3 years ago by fcxSanya

  • Keywords simple, review added; simple removed

comment:3 Changed 3 years ago by Philip

Hmm, I must have thought it'd be more complicated than that, but if that works then it's good - thanks :-)

comment:4 Changed 3 years ago by philip

  • Status changed from new to closed
  • Resolution set to fixed

(In [8016]) Fix #538 (Atlas has wrong icon in Start menu)

comment:5 Changed 3 years ago by anonymous

  • Milestone Unclassified deleted

Milestone Unclassified deleted

Note: See TracTickets for help on using tickets.