Units dont attack anymore

[elexis]

1) While testing r22393, units often don't attack nearby enemies anymore, even when they are attacked by enemies. Reproduce it by simulating some fights using cheats on a tiny map.

2) Attack orders against a specific target are sometimes followed by the unit walking to the target and then not attacking it.

[elexis]

sample 1

[elexis]

Sample 2

[elexis]

While reading r22345, I wonder if that could be related? From remembering what happened in the replay, perhaps the units thought they were in range to complete the assigned order but aren't according to the code that shall perform the order after having entered the target range. Same for #5462. I didn't investigate though.

[wraitii]

The issues sound related to chasing being broken (fixed by a combination of ​Phab:D1979, ​Phab:D1969, ​Phab:D1987, ​Phab:D1983 and possibly ​Phab:D1992).

(Edit: add links)

[elexis]

(Just for reference the detailed bugreport of Freagarach at ​https://code.wildfiregames.com/rP22345#33870, which might be unrelated to this issue, but I want to reference it somewhere where it is less likely to be forgotton.)

[wraitii]

This bug report, alongside others, is referenced ​here BTW - we might want to upgrade this to a release blocker?

[wraitii]

Can't reproduce post D2066. The diffs outlined above all play a role in various such situations, also D1987 and D1907.

[elexis]

Stop order seems to be working prima facie, except for units in formation where the units now just idle in formation when enemies are around.

[wraitii]

See #5519 for the formation issue, which isn't related. I'm thus closing this as it has been fixed.