Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5542 closed defect (fixed)

WARNING: JavaScript warning: gui/session/menu.js line 566 Script value conversion check failed: v.isBoolean() (got type undefined)

Reported by: Minohaka Owned by: elexis
Priority: Should Have Milestone: Alpha 24
Component: UI – In-game Keywords: regression
Cc: Patch:

Description

Clicking the diplomacy option on the upper right corner displays that warning.

Using A24, changeset: ​https://trac.wildfiregames.com/changeset/22560 I don't know when this started happening. The warning happens regardless of the type of game.

Change History (3)

comment:1 by elexis, 5 years ago

Component: Core engine → UI – In-game
Milestone: Backlog → Alpha 24

Thanks for the report. I am not expecting to have found every implicit undefined to boolean conversion as there are 86 enabled assignments and 223 hidden assignments, but I did look at all of them twice, now thrice.

comment:2 by elexis, 5 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 22562:

Add a missing undefined to booelan conversion for the diplomacy dialog in rP22538, fixes #5542.
Remove diplomacyMenuButton unused since introduction in rP12778.

comment:3 by elexis, 5 years ago

Keywords: regression added
Note: See TracTickets for help on using tickets.