Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5588 closed defect (fixed)

Unit max health not changing when promoted.

Reported by: Freagarach Owned by: Silier
Priority: Must Have Milestone: Alpha 24
Component: Simulation Keywords: regression
Cc: Patch: ​Phab:D2286

Description

In SVN 22890, when promoting a unit with the cheat from the dev. menu the max health is not changed. This could be not limited to only health but also to other components that cache values and only use "OnValueModification" to refresh them.

Change History (5)

comment:1 by Stan, 5 years ago

Keywords: regression added

comment:2 by Silier, 5 years ago

Milestone: Alpha 24 → Work In Progress
Owner: set to Silier

comment:3 by Silier, 5 years ago

Patch: → Phab:D2286

comment:4 by wraitii, 5 years ago

Resolution: → fixed
Status: new → closed

In 22912:

Make health correctly recalculate its cached values when the entity changes owner.

Following rP22767, the ModifierManager no longer sends ValueModificationMessages when an entity changes owner to/from INVALID_ENTITY. This happens in particular when the entity is renamed.

For now, components must check on their own in OwnershipChanged.

Reported By: Freagarach

Patch By: Angen

Reviewed By: wraitii

Fixes #5588

Differential Revision: ​https://code.wildfiregames.com/D2286

comment:5 by Silier, 5 years ago

Milestone: Work In Progress → Alpha 24
Note: See TracTickets for help on using tickets.