Ticket #559 (new task)

Opened 17 months ago

Last modified 16 months ago

Atlas brush shapes and tile/vertex styles

Reported by: Philip Owned by: DigitalSeraphim
Priority: Should Have Milestone: Backlog
Component: Game engine Keywords:
Cc:

Description

See patch from #83. Putting discussion here since it's not related to that ticket.

Change History

comment:1 Changed 17 months ago by Philip

Thanks, this looks mostly good, but there's a number of issues I've noticed from quick testing and reading that should probably be fixed:

  • Start editor, click Terrain, change size, get JavaScript error: section/terrain.js line 51: TypeError: this.tool is null
  • When size=1, vertex brushes don't render at all.
  • Tile brushes seem to be offset by half a tile from the mouse, particularly visible when size=1 (it ought to highlight the tile which the mouse is in).
  • The vertex brush looks a bit funny to me, but I suppose it makes sense. Maybe the dots should be white instead of green, else they're a bit hard to see on the green tiles on grass.
  • Whitespace/newlines in code like if(m_Brush->IsTileBased()){ ought to match the surrounding style.
  • There's some commented-out bits in a Brushes.cpp that look like they should be deleted.
  • New methods in TerrainOverlay.h should have some brief documentation.

comment:2 Changed 16 months ago by anonymous

  • Milestone Unclassified deleted

Milestone Unclassified deleted

comment:3 Changed 16 months ago by wacko

  • Milestone set to Backlog
Note: See TracTickets for help on using tickets.