Opened 3 years ago

Last modified 2 years ago

#5883 new defect

The details tooltip for mirages is not shown

Reported by: bb Owned by:
Priority: Should Have Milestone: Backlog
Component: Simulation Keywords:
Cc: Patch:

Description

The tooltip triggered by hovering over shield/sword icon in the selection panels is not shown for mirages.

Did not investigate which commit broke this, it used to work.

Change History (8)

comment:1 by Freagarach, 3 years ago

it used to work.

When? I just checked A23b and it didn't work there either?

[EDIT]: The tooltip is triggered, but there is nothing to be shown ;)

Last edited 3 years ago by Freagarach (previous) (diff)

comment:2 by wraitii, 3 years ago

Pretty sure this has never worked? There's no indication we ever copied that code for mirages. I'm not sure we should, either.

Note that non-mirage trees have the sword-shield icon too, but also nothing to show if you hover over it. That's probably a bug, but the ticket seems invalid otherwise.

comment:3 by wraitii, 3 years ago

In 24457:

Don't show the sword-shield icon if there is nothing to show.

Reviewed By: Freagarach

Refs #5883

Differential Revision: https://code.wildfiregames.com/D3258

comment:4 by wraitii, 3 years ago

Milestone: Alpha 24Alpha 25
Priority: Release BlockerMust Have

Per IRC yesterday, this would be nice to have but not an A24 RB.

comment:5 by wraitii, 3 years ago

Priority: Must HaveShould Have

comment:6 by wraitii, 3 years ago

In 25517:

Fix CanAttack for mirages following rP25465

CanAttack queries the miraged Resistance which did not exist, thus failing.
This mirages Resistance explicitly (fixing parts of #5883)

Fixes rP25465, reverts the mirage.xml change in rP25368

Refs #5883

Reported by: Asger_Spear

Differential Revision: https://code.wildfiregames.com/D4001

comment:7 by wraitii, 3 years ago

Milestone: Alpha 25Alpha 26

comment:8 by Freagarach, 2 years ago

Milestone: Alpha 26Backlog
Note: See TracTickets for help on using tickets.