Circular maps problems

[fabio]

• Map Hellenized Egipt: one Elefant on the left of the lake at North-West of the Player 1 disappears out of the map and never come back; update: after map update (r8533) this is no longer reproducible, but maybe it should still need to be fixed in the engine;
• the minimap doesn't cover all real map and units at map borders aren't visible on the minimap;
• camera can move outside of the circle at angles;
• the circle around the minimap shouldn't be black otherwise it's not obvious you are on a circular map, especially if starting player is not near border. It should have a decoration similar to other boxes.

[Mythos_Ruler]

I fixed the minimap so it is now obvious that it is a round map. Is the elephant thing fixed, Philip? I believe it could have been fixed with your pathfinding updates.

[fabio]

The Elephant disappearing is still not fixed as of r8526 (btw the lake is at NO of Player 1, not NE).

The new minimap looks nice but it has a lighter halo on the internal side (especially at NO) which it's not present on square maps: ​http://img575.imageshack.us/img575/4923/minimap.png also it doesn't cover all the real map, there is an external ring not shown on the minimap.

[fabio]

Another problem: when you click at the angles of the minimap (external to the circle so out of the visible map) camera moves here. It shouldn't do it.

[Mythos_Ruler]

"a lighter halo on the internal side"

Yes, I did that on purpose. Square maps are no longer a concern as we will be going exclusively with round maps from now on.

And the corners of the map still clickable is a known problem, but it is still good to have it listed in the ticket. :)

[fabio]

Updated description with new issue reported in later comments.

[ben]

In 11044:

Fixes camera constraints by clamping the camera focus point to within the map bounds instead of outside, since the constraints are partially based on terrain height. Should improve scrolling behavior on both circular and square maps. Refs #656, #850

[historic_bruno]

Fixed an annoying camera bounds problem. I believe it was the one referenced in this ticket, if not, let us know.

For the remaining problem, it sounds like expected pathfinding behavior, it won't let units cross from one passability class to another, even if they started on a tile with an unpassable class (for instance, out of the map world, or on land for a water unit, or on water for a land unit). So the lesson is don't design maps with units in unpassable areas or they'll get stuck :)