Opened 19 months ago

Closed 15 months ago

#6625 closed defect (fixed)

Fix DisplayVersion in NSIS on Windows

Reported by: Vladislav Belov Owned by: Vladislav Belov
Priority: Must Have Milestone: Alpha 27
Component: Core engine Keywords:
Cc: Patch: ​Phab:D4892

Description (last modified by Vladislav Belov)

Current we use inconsistent versioning for the Windows installer (r*-alpha instead of 0.0.*): ​https://trac.wildfiregames.com/browser/ps/trunk/source/tools/dist/0ad.nsi#L165

It also affects versioning in winget: ​https://github.com/microsoft/winget-pkgs/pull/80769

That might confuse users unfamiliar with r*-alpha format.

Refs: ​https://issuehint.com/issue/microsoft/winget-pkgs/56595

Change History (6)

comment:1 by Vladislav Belov, 19 months ago

Description: modified (diff)

comment:2 by Stan, 19 months ago

In 27105:

Bump version to alpha 27.
Last alpha 26 commit was ​Phab:rP27104

Accepted by: @asterix, @vladislavbelov
Discussed with: @Freagarach, @wraitii, @implodedok, @Itms

Refs: #6625

Differential Revision: ​https://code.wildfiregames.com/D4789

comment:3 by Vladislav Belov, 18 months ago

Priority: Should Have → Must Have

comment:5 by Stan, 16 months ago

Patch: → Phab:D4892

comment:6 by Stan, 15 months ago

Owner: set to Vladislav Belov

comment:7 by Vladislav Belov, 15 months ago

Resolution: → fixed
Status: new → closed

Fixed in r27512.

Note: See TracTickets for help on using tickets.