[PATCH] Stop using boost::filesystem::operator< so much

[Philip Taylor]

When launching the game and starting a map, Callgrind says boost::filesystem::operator< accounts for about 14% of instructions executed, which is a stupid waste. It's called about 90,000 times and does about 800,000 memory allocations (it's not just a straight string comparison).

The main callers are

CTextureManagerImpl::CreateTexture
CTextureManagerImpl::GetConverterSettings
CTextureManagerImpl::GetSettingsFile
CSkeletonAnimManager::GetAnimation
Landlord<>::add_
FileCache::Retrieve

which look like std::map<VfsPath, ...>. If these places don't care about ordered iteration, they should probably use a hash map instead. If they do care, they should probably store strings instead of VfsPaths so that lookups are cheaper.

[Rodolphe Ortalo]

Attached patch should bring usage of this operator to nearly 0. I followed your hints, and also changed the set type of the TextureCache object to boost::unordered_set to eliminate the last 23000 calls. (Checked with Callgrind.) Hope the patch is correct (have not done C++ for a while).

Please, feedback.

[Rodolphe Ortalo]

Patch with respect to source/ directory

[Jan Wassenberg]

Committed (along with a few more set -> unordered_set in CGUI), thanks!