Ticket #793 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Random maps don't report name

Reported by: Philip Owned by:
Priority: Nice to Have Milestone: Alpha 5
Component: Core engine Keywords:
Cc: historic_bruno

Description

session.js has reportPerformance which uses Engine.GetMapSettings().Name to say what map the profiling data applies to. When playing random maps, the Name seems to be undefined. I expect it would be best if that was the name of the random map script, and maybe reportPerformance should report the size and seed too, so we could (in theory) detect whether certain maps have significant performance problems.

Change History

comment:1 Changed 2 years ago by historic_bruno

The first part is easy to fix. But what do you think about using the initData that gets passed to sessions instead of Engine.GetMapSettings?()? It doesn't return all the data, like map type. Map type could be tested for "random" and in that case, the seed and map size could be included.

comment:2 Changed 2 years ago by Philip

That sounds sensible - I'm happy with any method that returns enough data to identify the map.

comment:3 Changed 2 years ago by ben

  • Status changed from new to closed
  • Resolution set to fixed

(In [9336]) Fixes slightly broken game attributes and setup. Includes random map size and seed in reportPerformance. Fixes #793. Fixes loading screen to use actual map names.

Note: See TracTickets for help on using tickets.