Fix unit double click selection with units of different ranks

[Kieran P]

Change the unit click selection code:

one click = selects single unit

two click = selects all units of the same type and rank

three clicks = selects on units of the same type (disregards rank)

[michael]

I suggest this:

• Double-click = Only units of that type and rank.

• Triple-click = Units of that type, regardless of rank.

[Kieran P]

Formatting broke. Deleted that comment. Lets try again:

triple click already selects units in the whole world (IIRC) while double click only selects within the view.

What about

single = only one unit

double = same type in view

triple = same type on map

and a modifier key, like CTRL which alters the above clicks to make it same rank as well?

[michael]

I think the triple-click=select all of same type and all rank is more useful than "selecting all units of same type and rank on the map." :) I never really understood the utility of the current triple-click functionality. I would find my setup more useful mas a player and has the added benefit of not introducing additional complexity with a modifier key. Discuss.

[historic_bruno]

Replying to michael:

I agree with this method, but I never want to select units off the screen. It's logical for each extra click to include more units.

[ben]

(In [9443]) Adjusts unit selection behavior to account for ranks. Triple-click now selects units regardless of their rank. Adds modifier hotkey to select units offscreen. Fixes #826.