Unused files in windows installer?

[fabio]

I installed 0ad alpha 4 for Windows on a friend PC and noticed that it install some files which appears to be unused by the game. Some examples: avcodec-51.dll avformat-51.dll avutil-49.dll FColladaD.dll (debug version, but standard version is already included) mozjs-ps-debug.dll (ditto) msvc* (many versions) and possibly others.

Maybe something can be removed.

[philip]

(In [9520]) Remove unused and very obsolete copy of ffmpeg. See #855.

[Philip Taylor]

The debug-mode DLLs are included in the Windows release for the same reason the source code is included - the idea is that it includes everything necessary to recompile (in debug or release mode) so you don't need to grab a copy from SVN instead.

In practice, maybe that's a silly idea - very few people downloading the game will care about the code, and those that do would be better off using the latest version from SVN instead, so it's just a waste of download size. It'd probably make sense to remove all of source/ and libraries/ and build/ from the Windows release, and then remove all the debug-mode DLLs too.

[philip]

(In [9777]) Remove the rarely-used source code option from the Windows installer. See #855.

[Philip Taylor]

Removing the debug DLLs would save about 3MB extra, which isn't huge so I won't bother now (to avoid adding more complexity to the installer build system, and to avoid the risk of deleting files that are still needed, since I can't test the output particularly easily). Would still be nice at some unspecified point in the future, though.

[ben]

In 15697:

Excludes debug DLLs from Windows installer, fixes #855