Ticket #91 (closed task: fixed)

Opened 7 years ago

Last modified 2 years ago

Player editor

Reported by: Philip Owned by: stilz
Priority: Nice to Have Milestone: Alpha 6
Component: Atlas editor Keywords:
Cc: stilz

Description (last modified by historic_bruno) (diff)

  • Edit number of players and their names, types (AI/human/other), civs, resources, starting location, etc.

Change History

comment:1 Changed 3 years ago by anonymous

  • Milestone Atlas Stage 2 deleted

Milestone Atlas Stage 2 deleted

comment:2 Changed 3 years ago by wacko

  • Milestone set to Backlog

comment:3 Changed 2 years ago by stilz

I'm currently working on it. GUI not finished yet, but probably it would look like this http://img87.imageshack.us/img87/1961/screenshotplayersconfig.png

comment:4 Changed 2 years ago by stilz

Patch is almost complete, but there is one weird thing about population limit. Upon saving population limit comes from player settings window. Let's say it is 100. After saving this number is present in XML map file. Then if I close map and reopen it this number changes to e.g. 154.

Function LoadPlayerSettings? (binaries/data/mods/public/simulation/helpers/Player.js) still gets correct number. Then it changes somewhere inside engine and finally, when I call my function that grabs population limit I get changed value. I suppose that engine changes population limit while adding new units.

What should be done with this? It is up to me to reload correct value?

comment:5 Changed 2 years ago by historic_bruno

That sounds like a bug outside the context of your patch, as long as you write the proper value to XML, it's OK. Of course if you want to look into what's causing it, that would be awesome too :)

comment:6 Changed 2 years ago by historic_bruno

  • Cc stilz added
  • Owner changed from Philip to stilz

comment:7 Changed 2 years ago by ben

(In [9608]) Adds player editor to Atlas scenario editor. See #91 Fixes object panel so the list of players updates correctly. Atlas map settings are now observable and shared between various panels. Fixes panels for maps missing settings (caused JSON error) Changes map reader so that entities with invalid players cause a warning but are not added to the game. That prevents further errors. Fixes #869 Uses map size choices from simulation/data/map_sizes.json instead of multiple locations. Fixes #787 Prepares Atlas map settings for undo/redo support

comment:8 Changed 2 years ago by k776

  • Milestone changed from Backlog to Alpha 6

comment:9 Changed 2 years ago by historic_bruno

  • Description modified (diff)

comment:10 Changed 2 years ago by historic_bruno

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.