Opened 13 years ago

Closed 13 years ago

#912 closed defect (invalid)

[PATCH] Fix handler_stack_top in input.cpp

Reported by: cristian Owned by:
Priority: Nice to Have Milestone: Alpha 7
Component: Core engine Keywords: patch, simple
Cc: Patch:

Description


Attachments (1)

fix.diff (982 bytes ) - added by cristian 13 years ago.

Download all attachments as: .zip

Change History (5)

by cristian, 13 years ago

Attachment: fix.diff added

comment:1 by Erik Johansson, 13 years ago

This is a fix for what? For all I know you may have said something in IRC or something, but in either case please add some more info to this ticket. Information not here doesn't exist for anyone who doesn't know it beforehand, and for that matter even if someone already knows it he might forget it. If it's just a test of how Trac works or something please resolve it as invalid.

comment:2 by Kieran P, 13 years ago

Keywords: patch simple review added; fix removed
Milestone: BacklogAlpha 7
Priority: Should HaveNice to Have
Summary: fix[PATCH] Fix handler_stack_top in input.cpp

comment:3 by Kieran P, 13 years ago

I've changed the topic, but a description as to why this patch is needed would be good.

comment:4 by historic_bruno, 13 years ago

Keywords: review removed
Resolution: invalid
Status: newclosed

Looks like it's working as designed. The counter handler_stack_top keeps track of the top of the input handler stack, which is really an array. When a new one is added it modifies that array entry and then increments the counter (it's a post-increment operator and C arrays are 0-based rather than 1-based).

Note: See TracTickets for help on using tickets.