[PATCH] Spaces in paths might break SpiderMonkey build

[Philip Taylor]

Spaces in paths might break the SpiderMonkey build with errors like

Can't open perl script "../build/autoconf/acoutput-fast.pl": No such file or directory
not updating unwritable cache ./config.cache
creating ./config.status
creating Makefile
sed: can't read ../Makefile.in: No such file or directory
...

Ought to test and maybe fix that.

[Jonathan Waller]

I just encountered this on linux mint 11.

[leper]

​Upstream suggests that the sourcedir shouldn't contain spaces. There is an ​upstream bugreport too.

Fixing this isn't trivial as the autoconf generated Makefiles and the configure script are not really designed to cope with spaces in paths.

[Philip Taylor]

In that case, I think it'd be nice if we could make update-workspaces.sh detect when it's being run in a path with spaces, and complain to the user with a description of the problem and what they should do (i.e. move everything to another path), since the SpiderMonkey output doesn't make it obvious.

[Philip Taylor]

Thanks, this seems to work fine (I've just changed it a bit to expand on the comment and error message).

[philip]

In 11380:

Fix #916 (complain about spaces in build paths), based on patch from philip_flohr

[historic_bruno]

Replying to philip:

In 11380:

Fix #916 (complain about spaces in build paths), based on patch from philip_flohr

Hmm this solution causes an error on OS X:

readlink: illegal option -- f
usage: readlink [-n] [file ...]

I guess the OS X ​readlink is slightly different.

I should also mention that this error doesn't cause update-workspaces.sh to fail.

[historic_bruno]

Replying to historic_bruno:

Replying to philip:

In 11380:

Fix #916 (complain about spaces in build paths), based on patch from philip_flohr

Hmm this solution causes an error on OS X:

readlink: illegal option -- f
usage: readlink [-n] [file ...]

I guess the OS X ​readlink is slightly different.

I should also mention that this error doesn't cause update-workspaces.sh to fail.

Same problem on FreeBSD.

[alan]

previously posted this patch in a wrong ticket:(

re-post it here:)

​http://trac.wildfiregames.com/attachment/ticket/514/update_workspaces.patch

[historic_bruno]

Replying to alan:

previously posted this patch in a wrong ticket:(

re-post it here:)

​http://trac.wildfiregames.com/attachment/ticket/514/update_workspaces.patch

That patch causes an error on Ubuntu (I haven't looked into why):

./update-workspaces.sh: 18: 0: not found

Also it doesn't work properly on OS X, if I create a new directory "this is a test", copy the patched update-workspaces.sh into it, and then from build/workspaces run ./this\ is\ a\test/update-workspaces.sh, it doesn't detect the spaces in the path (apparently it's using the cwd from where the script was called?). Using the same test case on Ubuntu, the readlink method finds the spaces and throws an error.

[historic_bruno]

Possible solutions for OS X: ​http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac

[ben]

In 16767:

Replaces usage of readlink -f in update-workspaces.sh with a perl one-liner, for compatibility with BSD and OS X, fixes #916

[historic_bruno]

I think a perl one-liner is better than trying to duplicate readlink -f's behavior in bash (like most other solutions). I tested with relative and absolute paths containing spaces and also symbolic links to the same, it was able to correctly detect the bad paths.