Opened 12 years ago

Last modified 12 years ago

#1223 closed enhancement

[PATCH] Redesign Sound System — at Version 12

Reported by: Kieran P Owned by: stwf
Priority: Must Have Milestone: Alpha 11
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by Kieran P)

Redesign the sound engine. Current one is broken and full of hacks.

  • During redesign, aim to solve the current issues, namely:
    • Current engine doesn't support Mac (#685, #931)
    • Music stops playing when returning to main menu (#946)
    • Suppress sound when minimized (#1218)
  • Further improve sound system (#961)
    • Sequential/random sounds
    • Fading sounds
    • Looping sounds

Change History (14)

comment:1 by Kieran P, 12 years ago

Description: modified (diff)

comment:2 by Kieran P, 12 years ago

Description: modified (diff)

comment:3 by Kieran P, 12 years ago

Description: modified (diff)
Last edited 12 years ago by Kieran P (previous) (diff)

comment:4 by historic_bruno, 12 years ago

Old ticket: #138 Related: #685

comment:5 by stwf, 12 years ago

Owner: set to stwf
Status: new → assigned

by stwf, 12 years ago

Attachment: new_sound_manager_1.diff​ added

comment:6 by stwf, 12 years ago

OK, this version builds on mac and linux

Fully supports the SoundGroup.xml as well as allowing for control of the Sound item from Javascript.

The missing feature is for position. It seems like the implementation of this merits some discussions on the forums.

Bugs carried over from the previous code include the playing of sounds that aren't on the screen and special intensity levels which also probably needs some discussion.

comment:7 by stwf, 12 years ago

Resolution: → fixed
Status: assigned → closed

comment:8 by stwf, 12 years ago

Keywords: patch review added
Resolution: fixed
Status: closed → reopened

comment:9 by stwf, 12 years ago

Keywords: sound, music patch review → sound, music, patch review
Resolution: → fixed
Status: reopened → closed
Summary: New Sound System → New Sound System [PATCH]

comment:10 by stwf, 12 years ago

Resolution: fixed
Status: closed → reopened

comment:11 by Kieran P, 12 years ago

Keywords: music removed
Summary: New Sound System [PATCH] → [PATCH] New Sound System

comment:12 by Kieran P, 12 years ago

Description: modified (diff)
Summary: [PATCH] New Sound System → [PATCH] Redesign Sound System

by stwf, 12 years ago

Attachment: patch12.diff​ added
Note: See TracTickets for help on using tickets.