[PATCH] Advance technologies cheat

[Idanwin]

A cheat that lets you advance to the final phase. Usefull for testing purposes.

[Idanwin]

patch that adds advance to city phase cheat

[sanderd17]

I included your patch for review, if that's ok for you.

The patch looks good enough to me. It will be nice for testing indeed (though it's a pity the cheat contains some characters that aren't usable in Atlas, but that's another bug).

Next time you create the patch, it's best to do it from the svn root directory though, that displays nicer in trac, and it's easier to apply for us (our svn directories don't get cluttered with patches).

[leper]

Idanwin: Read SubmittingPatches (though the really important part of that is adding the review keyword)

sanderd17: I don't know if the patch changed before you added the comment, but that patch is from the root svn dir (though it is a git patch, but that is just passing -p1 to patch).

[sanderd17]

Replying to leper:

sanderd17: I don't know if the patch changed before you added the comment, but that patch is from the root svn dir (though it is a git patch, but that is just passing -p1 to patch).

Oops, my bad.

[Idanwin]

Replying to leper:

Idanwin: Read SubmittingPatches (though the really important part of that is adding the review keyword)

Thank you, didn't find this before.

[historic_bruno]

"changephase" looks like it could be more generic by having a parameter of the phase name e.g. "town", "city", in case you want a cheat that only skips one phase.

Also, I think we should have a cheat that lets the player research any technology.

[Idanwin]

Replying to historic_bruno:

"changephase" looks like it could be more generic by having a parameter of the phase name e.g. "town", "city", in case you want a cheat that only skips one phase.

I don't see why you would want to go to town phase, everything available in town phase is also available in city phase

Replying to historic_bruno:

Also, I think we should have a cheat that lets the player research any technology.

Totally agree

[leper]

Replying to Idanwin:

Replying to historic_bruno:

"changephase" looks like it could be more generic by having a parameter of the phase name e.g. "town", "city", in case you want a cheat that only skips one phase.

I don't see why you would want to go to town phase, everything available in town phase is also available in city phase

Testing would be a good reason

Replying to historic_bruno:

Also, I think we should have a cheat that lets the player research any technology.

Totally agree

Will you implement this too? (and make the current cheat use this?)

[sanderd17]

Getting it out of the review queue for now, until the other requests are implemented.

[Michael]

Adds three cheats: phase cheat from Idanwin, get tech cheat and get all resource at once cheat

[Michael]

Merges 'DefaultParameter' and 'DefaultNumber'; additional flag 'isNumeric' can be set to force a numeric parameter.

[Michael]

Any comments on this?

[sanderd17]

Other idea discussed on IRC: ​http://irclogs.wildfiregames.com/2014-01-29-QuakeNet-%230ad-dev.log (starting 14:01)

The cheat should research the technology of the selected building. F.e. "brainiac 2" would research the second technology of the selected building, "brainiac 1 top" would research the top of the first technology pair (if the first technology is a pair).

This way, you still have to obey the rules somehow, but you can research techs without paying for it, or waiting for it, which is also good for testing.

[Michael]

Adds alternative syntax.

[Michael]

Now, as suggested by sanderd17, the brainiac cheat can be used with an alternative syntax:

brainiac number [pair]
or
brainiac name_of_technology

number: [1, number of possible techs in selected building]
pair: top|bottom (default: top, is only used for paired techs)

[Michael]

Just adds special phase support for generic celts.

[Michael]

@Sanderd17: Now generic celts are also handled. The patch chooses randomly what tech to use of the pair.

[sanderd17]

The patch isn't working for the changephase cheat in special cases (I tested with britons). The city phase gets researched (I see the change in territory), but the "III" is still shown in the CC.

I think we can remove that cheat altogether, and just have the generic technology cheat.

Also, if you split on spaces, don't do it on a single space " ", but use a regex: /\s+/ .

And is the "get rich" cheat your own idea? I don't think we should add another cheat to get resources.

[Michael]

Replying to sanderd17:

The patch isn't working for the changephase cheat in special cases (I tested with britons). The city phase gets researched (I see the change in territory), but the "III" is still shown in the CC.

The problem is that the brits and gauls do not use their custom phase yet. There is no entry in the civil_center.xml like

    <Technologies datatype="tokens">
      -phase_city_generic
      phase_city_britons
    </Technologies>

Is this intended or is it a bug ?

I think we can remove that cheat altogether, and just have the generic technology cheat.

We could do, but I like that one.

Also, if you split on spaces, don't do it on a single space " ", but use a regex: /\s+/ .

And is the "get rich" cheat your own idea? I don't think we should add another cheat to get resources.

Yeah, we can drop that.

[Michael]

Removed special phase for brits and gauls because they are only used in celts.

[sanderd17]

In 14712:

Add technologies cheat. Fixes #2072. Patch by boeseRaupe

[Michael]

JSON Cheat files were not included in the commit.

[O.Davoodi]

In 14718:

Adding the missing cheats from [14712]. Refs #2072