Opened 11 years ago

Closed 10 years ago

Last modified 6 years ago

#2071 closed defect (fixed)

Filters with no maps cause problems in match setup

Reported by: fabio Owned by:
Priority: Nice to Have Milestone: Alpha 14
Component: UI & Simulation Keywords:
Cc: Patch:

Description (last modified by elexis)

Select:

  • Match type: Random
  • Map Filter: Old Maps
  • Select Map: Random

Then start game -> an error appear.

Ideally filters should only appear if at least a true map (different from Random) is available.

Change History (5)

in reply to:  description comment:1 by historic_bruno, 11 years ago

Component: Core engineUI & Simulation
Priority: Should HaveNice to Have
Summary: error when using 'Random' Random map and a filter with no mapsFilters with no maps cause problems in match setup

A similar bug occurs for scenarios, too.

Replying to fabio:

Ideally filters should only appear if at least a true map (different from Random) is available.

That is probably true, but it will take some restructuring of gamesetup.js. The filter list is loaded before the map list, and the filters are only tested when the map list is reloaded. For A14, we can simply remove the "Old Maps" filter since it doesn't apply to any maps in SVN and it's very unlikely anyone is playing such a map.

comment:2 by ben, 11 years ago

In 13719:

Removes useless "old maps" filter from match setup, refs #2071

comment:3 by Stan, 10 years ago

Resolution: fixed
Status: newclosed

Should be fixed now.

comment:4 by Itms, 10 years ago

Milestone: BacklogAlpha 14

comment:5 by elexis, 6 years ago

Description: modified (diff)

In r19773 by Imarok:

Gamesetup - Hide mapfilter option if there are no maps matching the filter

Reviewed by: elexis. Fixes: #4423. Differential Revision: ​https://code.wildfiregames.com/D365

Note: See TracTickets for help on using tickets.