[PATCH] Improve UnitAI range query performance

[historic_bruno]

Currently, citizen soldiers' UnitAI can have two active range queries: one for finding attackable enemy entities, the other for finding gaia entities capable of attack (see SetupGaiaRangeQuery). This is a waste because it basically doubles the amount of work CmpRangeManager must do for those units. Instead, we could combine these into a single range query for gaia+enemies, then filter out non-attacking gaia entities from the query results in UnitAI.

Of course, it should be profiled before and after the change to ensure an improvement.

[sanderd17]

There's a similar case for BuildingAI

[dumbo]

[PATCH] for #2156 – UnitAI.js range queries, NOT profiled

[sanderd17]

The patch looks good, but you broke the tests though. (the test binary is in the same directory as the pyrogenesis binary, run it in a terminal to see where it breaks).

Btw, while you're on it. It might be nice to prefer attacking units over animals (in the AttackEntitiesByPreference method).

Also, see this: SubmittingPatches

[dumbo]

now passes a test also. thanks for sanderd

[sanderd17]

In 14473:

include gaia range query of UnitAI in general range query. Fixes #2156. Patch by dumbo