Opened 10 years ago

Last modified 5 years ago

#2301 new enhancement

Parse Scenario/Skirmish Map Sizes.

Reported by: Josh Owned by:
Priority: If Time Permits Milestone: Backlog
Component: UI – Game setup Keywords:
Cc: Patch:

Description

Currently scenario/skirmish maps don't display a map size. We should parse a size based off the number of tiles in a map and display the size in the game setup, the lobby, and the post-game.

Change History (9)

comment:1 by wraitii, 10 years ago

I've given this a look: it's not nearly as trivial as it sounds. Map size for RM is given because you choose it. Scenarios do not store any size info except in the .pmp
The sensible way to do this would probably be to pass a "mapSize" variable to g_mapsettings. However map settings are saved as an indiscriminate bloc of data, and map size is not a map setting in Atlas so it's not trivial either to change there. An alternative would be having the GUI ask directly for it, but then we'd need to parse the pmp a bit (the mapsize info is at the very top) before even loading, which is ugly.

comment:2 by wraitii, 10 years ago

In 14448:

Hide map size for skirmish and scenarios. Refs #2301.
Also fix my previous commit because obviously I had committed the wrong default value.

comment:3 by Stan, 10 years ago

Milestone: Alpha 16Alpha 17

Pushed since no new update.

comment:4 by historic_bruno, 10 years ago

I don't think we should fix this, maps could be arbitrary sizes that don't fit neatly into a predefined list (e.g. small, medium, large). Displaying the number of tiles in the UI, even if we had a way to parse it, would be ugly indeed. If it's really important to know, then maybe it should be included in the map description (say, a 2-player map that's huge).

in reply to:  4 comment:5 by Josh, 10 years ago

Priority: Should HaveIf Time Permits

Replying to historic_bruno:

I don't think we should fix this, maps could be arbitrary sizes that don't fit neatly into a predefined list (e.g. small, medium, large). Displaying the number of tiles in the UI, even if we had a way to parse it, would be ugly indeed. If it's really important to know, then maybe it should be included in the map description (say, a 2-player map that's huge).

I think they should be decently easy to categorize with some tile ranges, but it's certainly not critical.

comment:6 by historic_bruno, 10 years ago

I might add that map previews also indicate the map sizes.

comment:7 by Itms, 10 years ago

Milestone: Alpha 17Alpha 18

comment:8 by mimo, 9 years ago

Milestone: Alpha 18Backlog

comment:9 by Imarok, 5 years ago

Component: UI & SimulationGame setup

Move tickets to Game Setup as UI & Simulation got some sub components.

Note: See TracTickets for help on using tickets.