Opened 10 years ago

Closed 10 years ago

#2533 closed defect (fixed)

[PATCH] Disable ICU locale verification

Reported by: sanderd17 Owned by: sanderd17
Priority: Release Blocker Milestone: Alpha 16
Component: Core engine Keywords:
Cc: Yves, Adrián Chaves, historic_bruno, leper Patch:

Description

As ICU has a fallback model for locales (http://userguide.icu-project.org/locale#TOC-Fallback), it shouldn't be necessary to find a correct ICU locale to display the translations.

We already have some languages where the locale isn't present in ICU, but where we have translations for that languages. Most notably for Gaelic, but also Latin, and maybe more.

As such, I think we should remove the ICU check from validating locales (before A16, as Gaelic is supposed to be included with A16 now).

Attachments (2)

lng_verification.diff (1.1 KB ) - added by sanderd17 10 years ago.
lng_verification.2.diff (3.1 KB ) - added by sanderd17 10 years ago.

Download all attachments as: .zip

Change History (4)

by sanderd17, 10 years ago

Attachment: lng_verification.diff added

by sanderd17, 10 years ago

Attachment: lng_verification.2.diff added

comment:1 by sanderd17, 10 years ago

2nd version, still executes the check, and warns the user about the consequences of using a non-recognised locale.

Also disabled the script, as that apparently wasn't working (and because we now don't filter the scripts any more, it can break fallback, falling completely back to English.

Note: this patch contains a new string, marked as translatable. But it won't be translated. We might want to make it not translatable for this version.

Last edited 10 years ago by sanderd17 (previous) (diff)

comment:2 by sanderd17, 10 years ago

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 15122:

Fix locale verification to also allow ICU locales without data, but still don't allow bogus locales. Patch by Yves. Fixes #2533.

Note: See TracTickets for help on using tickets.