[PATCH] Change a scope in the Attack component for more modding flexibility

[Radagast]

In simulation/components/Attack.js the Schema is already stored in the Attack.prototype.

It would be nice for mods (e.g. convert_attack on 0ADMods) if the other schemas (e.g. bonusSchema, preferredClassesSchema, ..) also were stored in the prototype to easily reuse those schema defintions without hurting the single source principle (currently the global var schema variables have to be copied over in the AttackConvertAttack.js).

Please comment if there are any issues we should address.

Could be generalized for all components.

[Itms]

I think this is trivial so we can check it before A17. I don't know if the request is valid though.

[Stan]

@Itms did you have time to check if the request was valid ?

[Itms]

Stumbling across it again during the late release process, it's basically a feature so I'll commit it just after release. Sorry for forgetting it, rada :(

[Radagast]

No problem, itms. Thanks for having a look at it.

At the moment it's only relevant for ​convert_attack, which has turned out to be a not so ideal approach and is deprecated. So don't worry.

Yet for later modders it might still be a hurdle if the schema can't be accessed. thanks for considering it for A18.

[Itms]

In 15868:

Change a scope for a bunch of variables in the Attack component. This simple change allows modders to modify the whole attack schema.

Patch by Radagast, fixes #2671

[Itms]

Thanks for the patch, and good modding!