Opened 10 years ago

Closed 9 years ago

#2672 closed defect (fixed)

Allow enabling post processing effects in-game

Reported by: Adomas Jackevičius Owned by: Itms
Priority: Nice to Have Milestone: Alpha 18
Component: UI & Simulation Keywords:
Cc: Patch:

Description

Hello,

After installing 0 A.D. on Arch Linux when I launched it I set graphics options what I call to "max" and when I entered game it was BLACK SCEEEN. I got confused. Disabling one by one options in Graphics Options menu I found out that Post Processing causes the trouble. To enable Post Processing I had to restart the game, but the tooltip did not mention that. Not sure if it's a bug, but it should reload the engine so it displays correctly after settings change or smth.

Running Arch Linux x86_64 on GTX 780 GPU

Attachments (1)

PostProc_v1.patch (10.0 KB ) - added by dan_trev 10 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 by Stan, 10 years ago

Keywords: unanswered added

comment:2 by dan_trev, 10 years ago

PostProc_v1.patch fixes this. It was an initialization bug like the LOS bug from #2513.

Works by calling the Initialization routine whenever a public routine is called.

void CPostprocManager::Resize() is the exception. It will only recreate the buffers if the buffers are active. That way the current screen size is always correct without unwanted buffer updates.

void CPostprocManager::Cleanup() - moved to private

std::vector<CStrW> CPostprocManager::GetPostEffects() - changes fron const to static

Last edited 10 years ago by dan_trev (previous) (diff)

by dan_trev, 10 years ago

Attachment: PostProc_v1.patch added

comment:3 by dan_trev, 10 years ago

Keywords: review patch added; unanswered removed
Summary: Black Screen on Linux[PATCH] Black Screen on Linux

comment:4 by dan_trev, 10 years ago

Bug confirmed on Windows 7 64 bit and Debian Jessie x64bit

Last edited 10 years ago by dan_trev (previous) (diff)

comment:5 by Itms, 10 years ago

Milestone: BacklogAlpha 17

Don't forget to update the milestone. I didn't look at the patch at all, so I'll just put A17 and if it's not trivial we'll push it later.

comment:6 by dan_trev, 10 years ago

See #2514 for more information.

comment:7 by historic_bruno, 10 years ago

The patch works for me on Windows 7. Need to take a look at the code to see if it initializes/shuts down cleanly, if so we can commit it.

comment:8 by historic_bruno, 10 years ago

Summary: [PATCH] Black Screen on Linux[PATCH] Black Screen / Errors when enabling post processing effects in-game

#2561 was also a duplicate of this.

comment:9 by Itms, 10 years ago

Owner: set to Itms
Resolution: fixed
Status: newclosed

In 15843:

Allow enabling the post processing filters during a game.
Includes numerous code updates, also updated the copyright for r15841.

Patch by dan_trev, fixes #2672.

comment:10 by Itms, 10 years ago

Component: Core engineUI & Simulation
Keywords: review patch removed
Milestone: Alpha 17Alpha 18
Priority: Should HaveNice to Have
Summary: [PATCH] Black Screen / Errors when enabling post processing effects in-game[STRING] Allow enabling post processing effects in-game

Thanks for that patch!

I reopen it and push it because I'll have to update a string once the release is over. The fix is included for A17 though, along with the code updates.

comment:11 by Itms, 10 years ago

Resolution: fixed
Status: closedreopened

comment:12 by ben, 10 years ago

In 15905:

Fixes init of post processing effects, so they can be cleanly enabled/disabled at runtime. Fixes #2890, refs #2672, #2893.
Updates descriptions on options screen and fixes comment in default.cfg (smoothlos does not require preferglsl)

comment:13 by Itms, 9 years ago

Resolution: fixed
Status: reopenedclosed
Summary: [STRING] Allow enabling post processing effects in-gameAllow enabling post processing effects in-game

Ugh, seems like everybody had forgotten this one :)

Note: See TracTickets for help on using tickets.