Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#2832 closed defect (wontfix)

[PATCH] rome_infantry_spearman created advanced by default

Reported by: s0600204 Owned by: maveric
Priority: Should Have Milestone:
Component: UI & Simulation Keywords: simple patch
Cc: Patch:

Description (last modified by s0600204)

In the production entities list for rome_army_camp, the rome_infantry_spearman entry is suffixed with _a rather than _b.

What this means is that Roman Spearmen trained at a Army Camp start off as 'advanced', whilst at the barracks it is trained as 'basic'.

Attachments (1)

2832.patch (700 bytes ) - added by maveric 9 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 by Nikos, 10 years ago

Could this be on purpose since triarii were veterans?

in reply to:  1 ; comment:2 by Niek, 10 years ago

Replying to prodigal son:

Could this be on purpose since triarii were veterans?

No, the the rome_infantry_spearman_b is also a Triarius.

in reply to:  2 comment:3 by Nikos, 10 years ago

Replying to niektb:

Replying to prodigal son:

Could this be on purpose since triarii were veterans?

No, the the rome_infantry_spearman_b is also a Triarius.

I know, but it could have been left at basic for early game balance, while the other one got advaced as a bonus/flavor. Just guesses though, no clue if I'm right one this.

comment:4 by Niek, 10 years ago

The spearman trainable in the barracks is also advanced class. At the civic center no spearman is trainable.

Your explaination makes sense, prodigal_son.

comment:5 by s0600204, 10 years ago

Description: modified (diff)

Okay, so this might be intentional.

If it is, then should the file template for the _b variant be deleted (as it is not being used, except as a dependency for the _a variant, which can be altered) or retained (in case of a change in decision at a later date)?

by maveric, 9 years ago

Attachment: 2832.patch added

comment:6 by maveric, 9 years ago

Owner: set to maveric
Summary: rome_infantry_spearman created advanced by default[PATCH]rome_infantry_spearman created advanced by default

comment:7 by maveric, 9 years ago

Keywords: review patch added

comment:8 by maveric, 9 years ago

Summary: [PATCH]rome_infantry_spearman created advanced by default[PATCH] rome_infantry_spearman created advanced by default

comment:9 by maveric, 9 years ago

Description: modified (diff)

comment:10 by maveric, 9 years ago

Description: modified (diff)

comment:11 by Itms, 9 years ago

Keywords: review removed
Milestone: BacklogAlpha 19

Hello maveric, as you can see in the discussion above, the choice of advanced unit has been done on purpose. You can propose a patch for removing completely the "basic" version but I am not sure we want to do that.

If nobody has another opinion on that I guess we can close this ticket as wontfix.

Thanks for wanting to contribute! Don't hesitate to look into other tickets ;)

in reply to:  11 comment:12 by maveric, 9 years ago

Replying to Itms:

Hello maveric, as you can see in the discussion above, the choice of advanced unit has been done on purpose. You can propose a patch for removing completely the "basic" version but I am not sure we want to do that.

If nobody has another opinion on that I guess we can close this ticket as wontfix.

Thanks for wanting to contribute! Don't hesitate to look into other tickets ;)

Ah, okay. I will try something else)

comment:13 by s0600204, 9 years ago

Description: modified (diff)
Resolution: wontfix
Status: newclosed

comment:14 by fabio, 9 years ago

Milestone: Alpha 19
Note: See TracTickets for help on using tickets.