[PATCH] Use short pathfinder update when colliding with entities

[ickylevel]

The patch is not the final one, the code will have to be made cleaner. It's just here for testing purpose.

Instead of recalculating everything when a unit hits another entity, the pathfinder will just update the short range path, improving performance. The calculation is done immediately as opposed to the 'next' turn. This has to be checked and verified in multiplayer.

[historic_bruno]

Replying to ickylevel:

Instead of recalculating everything when a unit hits another entity, the pathfinder will just update the short range path, improving performance. The calculation is done immediately as opposed to the 'next' turn. This has to be checked and verified in multiplayer.

This actually sounds like it could be quite bad for performance, because instead of having that turn "buffer" before a recalculation, it happens immediately. Just imagine how often that could happen with a large group of units moving in a battle, or a unit that's trapped. This is more or less what happened the last time such a change was made (for the long pathfinder to make it more "responsive", and it's still in SVN).

[ickylevel]

I haven't tried to queue it so I could try and see if it increase further the framerate.

[ickylevel]

I just added pathfix_async which is the turn based version of it. It doesn't seem to do much of a difference (I am comparing using a save).

[Itms]

This change is obsolete considering the changes performed in Philip's patch (something rather similar was done there).

So I'm not going to close the ticket as invalid, I'll mark it as fixed when the pathfinding branch is merged.

Thanks for working on it anyways!

[Itms]

In 16751:

New long-range pathfinder.

Based on Philip's work located at ​http://git.wildfiregames.com/gitweb/?p=0ad.git;a=shortlog;h=refs/heads/projects/philip/pathfinder
Includes code by wraitii, sanderd17 and kanetaka.

An updated version of docs/pathfinder.pdf describing the changes in detail will be committed ASAP.

Running update-workspaces is needed after this change.

Fixes #1756.
Fixes #930, #1259, #2908, #2960, #3097
Refs #1200, #1914, #1942, #2568, #2132, #2563