Opened 9 years ago
Last modified 9 years ago
#2953 new defect
Terrain incorrect shadow rendering
| Reported by: | Niek | Owned by: | |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Backlog |
| Component: | Core engine | Keywords: | |
| Cc: | Patch: |
Description
It appears that the shadow on terrain is rendered incorrectly. This is especially evident on rough terrains.
My investigation shows that this is being introduced @L99 in terrain_common.vs when the object shadows(?) are rendered on the terrain. (at least removing that line gives the result in the 2nd image)
The shadows should look (more or less) like this:
Attachments (1)
Change History (7)
comment:1 by , 9 years ago
| Keywords: | review patch added |
|---|---|
| Summary: | Terrain incorrect shadow rendering → [PATCH] Terrain incorrect shadow rendering |
comment:2 by , 9 years ago
You shouldn't remove that line. (that line renders the object shadows on the terrain, check the tree in the 2nd image)
comment:3 by , 9 years ago
| Keywords: | review removed |
|---|
comment:4 by , 9 years ago
| Keywords: | patch removed |
|---|---|
| Milestone: | Alpha 18 → Backlog |
| Summary: | [PATCH] Terrain incorrect shadow rendering → Terrain incorrect shadow rendering |
comment:6 by , 9 years ago
Could be, although this one is static. Is #2070 with or without shadow filtering?
Note:
See TracTickets
for help on using tickets.
Maybe it's supposed to be v_shadow.xy = shadowScale.xy; instead of "v_shadow.xy *= shadowScale.xy; "