Opened 9 years ago

Last modified 9 years ago

#2975 new enhancement

[PATCH] [ATLAS] Defer loading of trigger scripts

Reported by: Niek Owned by: trompetin17
Priority: Should Have Milestone: Backlog
Component: Atlas editor Keywords: patch
Cc: Patch:

Description (last modified by Niek)

Currently the scripts are loaded when you load the map in Atlas for the first time (reloading doesn't matter). This means that I have to restart Atlas every time I make a change in a trigger script that I want to test.

It would be nice to defer that to a later stage.

Attachments (1)

2975.diff (11.0 KB ) - added by trompetin17 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by Niek, 9 years ago

Description: modified (diff)

by trompetin17, 9 years ago

Attachment: 2975.diff added

comment:2 by trompetin17, 9 years ago

Keywords: review patch added
Owner: set to trompetin17
Summary: [ATLAS] Defer loading of trigger scripts[PATCH] [ATLAS] Defer loading of trigger scripts

this patch enable partially hotloading from atlas, due some limitations from wxWidget on wxFileSystemWatcher, in osx doesn't work (you need to rename and rollback the file to bypass this limitation)

Implementation limitations: this class is currently implemented for MSW,
OS X and GTK ports but doesn't detect all changes correctly everywhere: 
under MSW accessing the file is not detected (only modifying it is) 
and under OS X neither accessing nor modifying is detected 
(only creating and deleting files is). 
Moreover, OS X version doesn't currently collapse pairs of create/delete
 events in a rename event, unlike the other ones.

source http://docs.wxwidgets.org/trunk/classwx_file_system_watcher.html

So you can change a trigger and just reload the map

comment:3 by historic_bruno, 9 years ago

I haven't looked at the patch too closely yet, but is it really necessary to use wxWidgets file watching? The engine should have enough hotloading capability and it should work in Atlas too.

comment:4 by Itms, 9 years ago

Keywords: review removed

Removing the "review" keyword to clean up a bit the queue, don't forget to add it back when you come up with new elements about using engine hotloading ;-)

comment:5 by Stan, 9 years ago

Hey trompetin17 anything new ?

comment:6 by Stan, 9 years ago

Milestone: Alpha 18Alpha 19

comment:7 by Itms, 9 years ago

Milestone: Alpha 19Backlog

Backlogging due to lack of progress.

Note: See TracTickets for help on using tickets.