Opened 9 years ago

Closed 9 years ago

#3217 closed defect (fixed)

OOS during staff multiplayer

Reported by: historic_bruno Owned by: sanderd17
Priority: Must Have Milestone: Alpha 19
Component: Core engine Keywords:
Cc: Patch:

Description

We had an OOS near the beginning of the game, not at the very start, but after a few minutes. The game seemed to continue normally after that. Map: Caspian Sea (2v2)

Attachments (4)

historicbruno_oos_dump_20150503.zip (372.8 KB ) - added by historic_bruno 9 years ago.
commands.txt (623.0 KB ) - added by historic_bruno 9 years ago.
leper_host.zip (414.4 KB ) - added by leper 9 years ago.
leper's oos dump
oos_dump.txt.zip (436.4 KB ) - added by trompetin17 9 years ago.
trompetin17 oos

Download all attachments as: .zip

Change History (7)

by historic_bruno, 9 years ago

by historic_bruno, 9 years ago

Attachment: commands.txt added

by leper, 9 years ago

Attachment: leper_host.zip added

leper's oos dump

by trompetin17, 9 years ago

Attachment: oos_dump.txt.zip added

trompetin17 oos

comment:1 by elexis, 9 years ago

historicbruno and lepers oos_dump are identical (besides an irrelevant waypoint flag).

trompetin and lepers oos dumps are different:

--- oos_dump_leper.txt	2015-05-03 20:51:48.000000000 +0200
+++ oos_dump_trompetin17.txt	2015-05-03 15:20:12.000000000 +0200
@@ -543582,11 +543582,11 @@
     "food": 0,
     "metal": 0,
     "stone": 0,
     "wood": 100
   },
-  "progress": 0,
+  "progress": 0.0011111111111111111,
   "initialised": true
 }
   Health:
     object: {
   "maxHitpoints": 900,

The build progress is probably different because of the female inspiration aura.

Probably dupe: #3181. Also contains a replay on a scenario map and serializationtest data (r16590). Maybe related: #3188 There were some changes to the AuraManager that have been reverted in r16591. Im sure the bug is older than this revision though.

comment:2 by sanderd17, 9 years ago

The cause is r16470

A gui call can influence the state. So a player who selects an uninitialized building gets a different state. Though the final outcome is still the same.

The fix is simple, don't store the progress to the state.

comment:3 by sanderd17, 9 years ago

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 16622:

Fix OOS caused by saving build progress. Fixes #3217

Note: See TracTickets for help on using tickets.