OOS on r16552

[leper]

I played a capturing match agains z and we got an OOS error (no noticable difference, as we continued playing) a few minutes in.

--- oos_dump_leper.txt	2015-04-20 17:11:03.229287000 +0200
+++ oos_dump_z.txt	2015-04-20 18:12:50.525870397 +0200
@@ -662162,21 +662162,21 @@
   "buildMultiplier": 1,
   "previewEntity": 0,
   "finalTemplateName": "structures/athen_house",
   "owner": 2,
   "costs": {
     "food": 0,
     "metal": 0,
     "stone": 0,
     "wood": 150
   },
-  "progress": 0,
+  "progress": 0.0008333333333333334,
   "initialised": true
 }
   Health:
     object: {
   "maxHitpoints": 1200,
   "hitpoints": 1,
   "regenRate": 0
 }
   Identity:
   RallyPoint:
@@ -662187,25 +662187,25 @@
   Sound:
   StatusBars:
   Visibility:
     object: {
   "retainInFog": true,
   "alwaysVisible": false,
   "preview": false,
   "activated": false
 }
 
-- id: 536870913
+- id: 536870914
   type: local
   Position:
     in world: false
-    territory: 1
+    territory: 2
     rot x: 0
     rot y: 0
     rot z: 0
     altitude: 0
     relative: true
     floating: false
     constructionprogress: 0
     anchor: "upright"
     turret parent: 0
   Vision:
@@ -662214,20 +662214,20 @@
     r: 1
     g: 1
     b: 1
     anim run threshold: 0
     anim name: "idle"
     anim once: false
     anim speed: 1
     sound group: ""
     anim desync: 0.05
     anim sync repeat time: 0
-    seed: 536870913
+    seed: 536870914
     actor: "props/special/common/waypoint_flag.xml"
   Visibility:
     object: {
   "retainInFog": true,
   "alwaysVisible": true,
   "preview": false,
   "activated": false
 }
 

[elexis]

I got this oos error in serializationtest + ooslog mode after 15 turns without rejoining. Commands.txt and ooslog data for both clients provided.

[elexis]

As far as I can see the only differences are IDs and progress. Here the diffs of turn 15 and 16 which contains those 2 types of diffs already:

Turn 15 diff:

--- 29574/00015.txt	2015-04-27 23:33:07.619099000 +0200
+++ 29549/00015.txt	2015-04-27 23:33:07.051109000 +0200
@@ -330676,14 +330676,14 @@
   "activated": false
 }
 
-- id: 536870916
+- id: 536870917
   type: local
   Decay:
   Footprint:
   Obstruction:
     active: false
     moving: false
-    control group: 536870916
+    control group: 536870917
     control group 2: 0
     tag: 0
     flags: 5
@@ -330759,14 +330759,14 @@
   "activated": false
 }
 
-- id: 536870917
+- id: 536870918
   type: local
   Decay:
   Footprint:
   Obstruction:
     active: false
     moving: false
-    control group: 536870917
+    control group: 536870918
     control group 2: 0
     tag: 0
     flags: 5

Turn 16 diff:

--- 29574/00016.txt	2015-04-27 23:33:09.775060000 +0200
+++ 29549/00016.txt	2015-04-27 23:33:09.503065000 +0200
@@ -1,4 +1,4 @@
-State hash: c68e1ec92d6a3f43303eb67d9985cbbe
+State hash: 975bbef77ebfb1b9d3e23dbbe7db05b4
 
 rng: "33667240814915"
 entities:
@@ -330112,7 +330112,7 @@
     "stone": 1000,
     "wood": 1000
   },
-  "progress": 0,
+  "progress": 0.0002,
   "initialised": true
 }
   Health:
@@ -330670,14 +330670,14 @@
   "activated": false
 }
 
-- id: 536870916
+- id: 536870917
   type: local
   Decay:
   Footprint:
   Obstruction:
     active: false
     moving: false
-    control group: 536870916
+    control group: 536870917
     control group 2: 0
     tag: 0
     flags: 5
@@ -330753,14 +330753,14 @@
   "activated": false
 }
 
-- id: 536870917
+- id: 536870918
   type: local
   Decay:
   Footprint:
   Obstruction:
     active: false
     moving: false
-    control group: 536870917
+    control group: 536870918
     control group 2: 0
     tag: 0
     flags: 5

[elexis]

The test above was done with r16590.

[elexis]

Maybe the difference in the build progress is caused by female inspiration aura. I had men affected by that bonus in the game above.

Also there have been error messages related to adding an aura bonus in #3188.

[elexis]

With regards to the original oos posted here (leper / z):

This is a full diff with 20 lines of unified context:

--- oos_dump_leper.txt	2015-04-20 17:11:03.000000000 +0200
+++ oos_dump_z.txt	2015-04-20 18:12:50.000000000 +0200
@@ -662142,92 +662142,92 @@
     0,
     0
   ],
   "miraged": [
     false,
     false,
     false
   ],
   "seen": [
     false,
     false,
     true
   ]
 }
   Foundation:
     object: {
   "committed": false,
   "builders": [
     7187
   ],
   "buildMultiplier": 1,
   "previewEntity": 0,
   "finalTemplateName": "structures/athen_house",
   "owner": 2,
   "costs": {
     "food": 0,
     "metal": 0,
     "stone": 0,
     "wood": 150
   },
-  "progress": 0,
+  "progress": 0.0008333333333333334,
   "initialised": true
 }
   Health:
     object: {
   "maxHitpoints": 1200,
   "hitpoints": 1,
   "regenRate": 0
 }
   Identity:
   RallyPoint:
     object: {
   "pos": [],
   "data": []
 }
   Sound:
   StatusBars:
   Visibility:
     object: {
   "retainInFog": true,
   "alwaysVisible": false,
   "preview": false,
   "activated": false
 }
 
-- id: 536870913
+- id: 536870914
   type: local
   Position:
     in world: false
-    territory: 1
+    territory: 2
     rot x: 0
     rot y: 0
     rot z: 0
     altitude: 0
     relative: true
     floating: false
     constructionprogress: 0
     anchor: "upright"
     turret parent: 0
   Vision:
   VisualActor:
     base actor: "props/special/common/waypoint_flag.xml"
     r: 1
     g: 1
     b: 1
     anim run threshold: 0
     anim name: "idle"
     anim once: false
     anim speed: 1
     sound group: ""
     anim desync: 0.05
     anim sync repeat time: 0
-    seed: 536870913
+    seed: 536870914
     actor: "props/special/common/waypoint_flag.xml"
   Visibility:
     object: {
   "retainInFog": true,
   "alwaysVisible": true,
   "preview": false,
   "activated": false
 }

So the only difference is the waypoint flag (irrelevant) and the build progress of a house (very likely a dupe of #3217).

[elexis]

With regards to the other oos dump I attached:

On turn 15 there is a crocodile and a cavalry spearmen that have different IDs. I remember those units fought immediately after the game started. For turn 15 however, the hash matches.

Therefore the different IDs on turn 16 did not cause the oos. Because of that, the oos was caused by the only other difference on turn 16, which is the progress of the wonder that I started to build with men and women. So its possibly a dupe of #3217 or has to do with the female inspiration aura.

I had used two instances of 0ad in serializationtestmode. And the oos happened without rejoin. Thats why it is even more likely that its #3217.

If female inspiration aura would cause out-of-sync without rejoin, we would have noticed it way more often and earlier. This oos was reported for r16552, i.e. only 6 days after the cause of #3217, i.e. r16470 was committed.

[historic_bruno]

Replying to elexis:

On turn 15 there is a crocodile and a cavalry spearmen that have different IDs. I remember those units fought immediately after the game started. For turn 15 however, the hash matches.

Just FYI, those entities are "local" and not part of the simulation hash / OOS check. Building previews, corpses, rally point entities, etc. that are local to each player are local entities. They are included in the OOS dump in case they influence the synchronized state, which shouldn't happen. Typically you can ignore differences in local entities.