Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3675 closed defect (fixed)

[PATCH] Ariovistus Listed as Gallic Leader

Reported by: Andrettin Owned by: Stan
Priority: Should Have Milestone: Alpha 20
Component: UI & Simulation Keywords:
Cc: Patch:

Description

Ariovistus is listed as a Gallic leader (https://github.com/0ad/0ad/blob/master/binaries/data/mods/public/simulation/data/civs/gaul.json), but he was Germanic, and likely belonged to the Suebi tribe.

Attachments (1)

3675.diff (554 bytes ) - added by Stan 8 years ago.
Does the above

Download all attachments as: .zip

Change History (6)

comment:1 by historic_bruno, 8 years ago

Component: Core engineUI & Simulation

I guess the name was mistakenly taken from a list of leaders who fought against the Romans in the Gallic Wars. I don't know that Cassivellaunus should be on the list either, Wikipedia classifies him as a British Celt.

How about adding Cativolcus, Cingetorix and Viridovix in their place? Unless someone else has better suggestions.

Here's the original names ticket: #1582

Last edited 8 years ago by historic_bruno (previous) (diff)

by Stan, 8 years ago

Attachment: 3675.diff added

Does the above

comment:2 by Stan, 8 years ago

Keywords: review patch added
Milestone: BacklogAlpha 20
Owner: set to Stan
Status: newassigned
Summary: Ariovistus Listed as Gallic Leader[PATCH] Ariovistus Listed as Gallic Leader

in reply to:  1 comment:3 by Andrettin, 8 years ago

Replying to historic_bruno:

I guess the name was mistakenly taken from a list of leaders who fought against the Romans in the Gallic Wars. I don't know that Cassivellaunus should be on the list either, Wikipedia classifies him as a British Celt.

How about adding Cativolcus, Cingetorix and Viridovix in their place? Unless someone else has better suggestions.

Here's the original names ticket: #1582

Thanks! Yes, Cassivelaunus was AFAIK a Briton. I don't really know much (I've actually heard of them for the first time now) about Cativolcus, Cingetorix or Viridovix to make a comment on their inclusion.

comment:4 by Itms, 8 years ago

Resolution: fixed
Status: assignedclosed

In 17612:

Fix some Gallic leader names, based on historic_bruno's suggestions. Fixes #3675

comment:5 by Itms, 8 years ago

Keywords: review patch removed

Stan, beware with commas. The patched json file wasn't valid. Thanks for bumping that to the RQ though!

Note: See TracTickets for help on using tickets.