Correctly handle commands for multiple units

[Itms]

When there are multiple units in the selection, we're facing several problems, which arise from the fact that the GUI uses the first unit of the selection (this first unit being the one with the lowest entity ID).

Problems include:

• The back-to-work button does not always show up (workaround included in r17880 and reverted afterwards)
• #2205
• #3302
• Building structures when female citizens and soldiers are selected together

and possibly others.

This should be fixed by passing selection instead of unitEntState from unit_commands to selection_panels and change the code depending on that. (comment:8)

[Itms]

In 17885:

Revert r17880, refs #3745, refs #3823

[svott]

I solved the back-to-work problem again in a more general way for the middle panel, so that is should also fix problems with other commands

Further:

#2205: I think that is another problem. Related to the middle panel: there is not enough space for all icons when units and structures are selected together. Thus, it needs a redesign in another task.

#3302: It looks like that it has another cause that is not related to here.

last bullet point: I don't see the problem. maybe it is solved in another ticket already?

[sanderd17]

Some remarks:

• It's not common to mark an argument as "UNUSED" in JS.
• It would be nice if you assured us that there's no problem with passing the same selection list every time (it could be modified by some methods).
• When you alter the arguments of a function that has javaDoc, you should alter the documentation too.

[Stan]

Any updates ?

[bb]

How does changing L231 of input.js to:

if (r && r.possible) // return true if it's possible for one of the entities

effect this ticket? see #252 and #3492

[svott]

@bb: I don't know. Don't? @sanderd17: well, is there another way to get rid of unused arguments? I don't see a possibility in that case because the (general) getItem function needs a unitEntState argument at first place

how can I assure that there is no problem with passing the list? (There are other entries (g_SelectionPanels.Gate i.e.) those use the "selection" parameter as well)

[Imarok]

rebased

[elexis]

As far as I can see unitEntState shouldn't be passed at all from unit_commands to selection_panels. In some cases it might happen to be a check that works as the player can't select multiple units if the first selected one isn't an own unit. But if the GUI should take all selected units into account, then g_Selection must be processed in every case.