Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3841 closed enhancement (fixed)

[PATCH] Ingame player summary screen and allied resource/population tooltips

Reported by: elexis Owned by: Imarok
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

1. Ingame player score The ingame summary screen could become available to players, so they can check their own stats (suggested by scythetwirler) and optimize their strategy if desired.

Impact: Players who attempt to benefit ("cheat") from seeing their own score still need to invest time. The score alone doesn't show any more information than what is already available to the player (besides the exact quantities).

2. New tech: Additionally, after researching a new tech at the market (could be a successor the to shared-ally-vision tech aka Cartography), players should be able to see the score of mutual allies. It should always hide the score of enemies. Observers should always be able to see the complete score. A new icon will be needed for the tech.

3. Session GUI tooltips: Once the tech is researched, the player should be able to see the resources and population number of mutually allied players in the tooltips of the session GUI. This way the player doesn't need to open the summary score and can check allied overall state quicker and more frequently.

Impact:

  • Incentivizes team play.
  • Requires a decision from the player whether to invest in the tech or save resources.
  • The neutral diplomacy stance becomes a bit more interesting in diplomacy games (as mutually neutral players don't see the score, but are prevented from attacking each other).

Attachments (7)

3841_ingame_summary_v0.3.patch (6.8 KB ) - added by Imarok 8 years ago.
Make summary accesible to see your own score. Adds a tech to see the score of your allies that requires shared vision . Missing: a proper name for this tech, an icon, proper costs and the tooltip proposed in 3)
3841_ingame_summary_v1.patch (9.3 KB ) - added by Imarok 8 years ago.
Enable ingame summary for everyone. You can ony see your own score. If you unlock shared vision you can see the score of your allies in the summary and in the tooltip of your own resource/pop (top panel)stat
3841_ingame_summary_v1.1.patch (8.0 KB ) - added by Imarok 8 years ago.
style fixes. use map and filter. Don't introduce a new variable for hasSharedLos
3841_ingame_summary_v1.2.patch (7.9 KB ) - added by Imarok 8 years ago.
Improves the resource translation
3841_ingame_summary_v1.3.patch (7.8 KB ) - added by Imarok 8 years ago.
style; remove .map().filter()
3841_ingame_summary_v1.4.patch (10.0 KB ) - added by Imarok 8 years ago.
adapted guiInterface tests; create and use Player.prototype.HasSharedLos
3841_ingame_summary_v1.5.patch (10.5 KB ) - added by Imarok 8 years ago.
Some style fixes and one translate more proposed by elexis

Download all attachments as: .zip

Change History (14)

comment:1 by Imarok, 8 years ago

Owner: set to Imarok

by Imarok, 8 years ago

Make summary accesible to see your own score. Adds a tech to see the score of your allies that requires shared vision . Missing: a proper name for this tech, an icon, proper costs and the tooltip proposed in 3)

by Imarok, 8 years ago

Enable ingame summary for everyone. You can ony see your own score. If you unlock shared vision you can see the score of your allies in the summary and in the tooltip of your own resource/pop (top panel)stat

comment:2 by Imarok, 8 years ago

Keywords: review patch added
Milestone: BacklogAlpha 21
Summary: Ingame player summary screen and allied resource/population tooltips[PATCH] Ingame player summary screen and allied resource/population tooltips

by Imarok, 8 years ago

style fixes. use map and filter. Don't introduce a new variable for hasSharedLos

by Imarok, 8 years ago

Improves the resource translation

by Imarok, 8 years ago

style; remove .map().filter()

comment:3 by fatherbushido, 8 years ago

  • i didn't noticed bugs while doing a quick test,
  • Don't forget to make it coherent with the test in simulation/components/tests/test_GuiInterface.js (it will be broken, as you add "hasSharedLos" to GuiInterface).
  • as noticed by elexis, cmpTechnologyManager && cmpTechnologyManager.IsTechnologyResearched("unlock_shared_los"), is a bit ugly in GuiInterface, perhaps you may move it to Player to be more coherent with the actual code.
Last edited 8 years ago by fatherbushido (previous) (diff)

by Imarok, 8 years ago

adapted guiInterface tests; create and use Player.prototype.HasSharedLos

by Imarok, 8 years ago

Some style fixes and one translate more proposed by elexis

comment:4 by elexis, 8 years ago

Resolution: fixed
Status: newclosed

In 18533:

Ingame summary screen and allied resource / population tooltips for active players. Patch by Imarok, also reviewed by fatherbushido and discussed with mimo, fixes #3841.

Shows (only) the stats of the current player in the summary screen while playing.
Also shows those of mutual allies too if the shared vision tech is researched.
Display the resources and population counts of allies in the tooltips of the top panel.
Use a sprintf for the pop / limit ratio and remove hardcoded resource strings in the XML, refs #3934.

comment:5 by elexis, 8 years ago

Cc: mimo Niek removed
Keywords: review removed

Thanks for all your patches! I hope this feature will be well received.

Here the few characters I changed:

  • for that comment in menu.js: SharedLos -> shared ally vision
  • one trailing whitespace in menu.js
  • one missing space in session.js after a comma
  • Using getLocalizedResourceName instead of accessing localisedResourceNames for consistency (also avoiding a reference to a global that isn't prefixed with g_)

Also wrote a ticket about this weird platform dependent bug found: #4107.

Last edited 8 years ago by elexis (previous) (diff)

comment:6 by elexis, 8 years ago

In 18537:

Add missing round to r18533, refs #3841.

comment:7 by elexis, 7 years ago

In 18982:

Hide the resources of defeated allies in the top panel tooltips, refs #3841.

Note: See TracTickets for help on using tickets.