[PATCH] sound notification when people join hosted game menu

[Andy Alt]

I think it would be helpful to have an audible alert when someone joins a hosted game lobby. I'd feel more free to minimize the window while checking on various other things while I"m waiting for the room to fill up. What other advantages would there be to this feature?

The forum thread for this patch: ​Link

[Andy Alt]

Forum post for this patch: ​Link

[Andy Alt]

option added

[Imarok]

patch looks good and works Only remark: L751: if (Engine.ConfigDB_GetValue("user", "sound.notify.join") == "true") should be if (Engine.ConfigDB_GetValue("user", "sound.notify.join"))

[Andy Alt]

applying Imarok's suggestion

[Imarok]

I tested it and it works perfectly The code seems to be ok too

[Imarok]

You should add an entry in default.cfg for this option. (like you've done in r18545)

[elexis]

This will presumably not be the last acoustical notification when something happens (f.e. #4159). If we were to continue adding one global and that check for every notification type, it would become a bit messy.

The code that the patch shares with r18545 should be merged. Instead of 2 globals for the times, it could use a global object where the keys are the names of the default.cfg entries:

var g_NotificationTimes = {
	"nick": ...,
	"join": timestamp
}

and use a function that gets passed the config entry and soundfile string.