Opened 8 years ago
Last modified 5 years ago
#4101 closed enhancement
[PATCH] sound notification when people join hosted game menu — at Version 7
| Reported by: | Andy Alt | Owned by: | Andy Alt |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 24 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description (last modified by )
I think it would be helpful to have an audible alert when someone joins a hosted game lobby. I'd feel more free to minimize the window while checking on various other things while I"m waiting for the room to fill up. What other advantages would there be to this feature?
The forum thread for this patch: Link
Change History (11)
comment:1 by , 8 years ago
| Keywords: | simple added |
|---|
comment:2 by , 8 years ago
| Keywords: | patch added |
|---|---|
| Milestone: | Backlog → Alpha 21 |
| Owner: | set to |
| Status: | new → assigned |
| Summary: | sound notification when people join hosted game menu → [PATCH] sound notification when people join hosted game menu |
comment:3 by , 8 years ago
by , 8 years ago
| Attachment: | JoinGameAlert.patch added |
|---|
comment:4 by , 8 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | rfc added |
by , 8 years ago
| Attachment: | JoinGameAlert.3.patch added |
|---|
comment:5 by , 8 years ago
patch looks good and works
Only remark:
L751: if (Engine.ConfigDB_GetValue("user", "sound.notify.join") == "true") should be if (Engine.ConfigDB_GetValue("user", "sound.notify.join"))
comment:6 by , 8 years ago
| Keywords: | review added; rfc removed |
|---|
I tested it and it works perfectly The code seems to be ok too
comment:7 by , 8 years ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
Forum post for this patch: Link