Opened 8 years ago
Last modified 11 months ago
#4299 assigned defect
[PATCH] Music track should not restart when switching the menu
Reported by: | elexis | Owned by: | Grapjas |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 27 |
Component: | Music & Sound FX | Keywords: | patch, simple |
Cc: | Patch: | Phab:D4922 |
Description (last modified by )
The currently played track is restarted when entering the multiplayer lobby, or when returning from any page to the main menu (whenever global.music.setState
is called in the JS files).
The number of resets should be minimized - it is basically only needed when first starting the game and when leaving the summary screen after ending a game (the summary screen should still play the win / defeat music of the players civ).
Attachments (1)
Change History (13)
comment:2 by , 7 years ago
Keywords: | patch rfc added |
---|---|
Milestone: | Backlog → Alpha 22 |
Owner: | set to |
Status: | new → assigned |
Summary: | Music track should not restart when switching the menu → [PATCH] Music track should not restart when switching the menu |
follow-up: 4 comment:3 by , 7 years ago
Keywords: | rfc removed |
---|
Replying to vladislavbelov:
Should any music plays in the summary screen, when player exited (not finished a game)?
For my taste, there should always be some music track in the background. So that would indeed be better to play the main menu track at that point, not only when entering the menu.
Also it seems weird to mute the music if there is a message box popping up in singleplayer (i.e. when the game is paused), would you agree?
comment:4 by , 7 years ago
Replying to elexis:
For my taste, there should always be some music track in the background. So that would indeed be better to play the main menu track at that point, not only when entering the menu.
Ok, I will implement the default music in the summary.
Also it seems weird to mute the music if there is a message box popping up in singleplayer (i.e. when the game is paused), would you agree?
I agree: not mute but set the volume to 0.5x or something like this.
comment:5 by , 7 years ago
Milestone: | Alpha 22 → Work In Progress |
---|
Moving to the Work In Progress milestone, since there is a patch asking for feedback, but since it is not strictly bound to a specific release.
comment:6 by , 3 years ago
Keywords: | simple removed |
---|---|
severity: | → simple |
comment:7 by , 3 years ago
Keywords: | simple added |
---|
comment:8 by , 15 months ago
Description: | modified (diff) |
---|---|
Milestone: | Work In Progress → Backlog |
Owner: | removed |
Status: | assigned → new |
comment:9 by , 15 months ago
Milestone: | Backlog → Alpha 27 |
---|---|
Owner: | set to |
Status: | new → assigned |
comment:10 by , 15 months ago
Patch: | → Phab:D4922 |
---|
comment:11 by , 12 months ago
Milestone: | Alpha 27 → Alpha 28 |
---|
Should win/defeat music play after exiting from the summary screen? And should any music plays in the summary screen, when player exited (not finished a game)?