Typo in MaxDistance in BuildRestrictions

[PASilva]

Hi, using the attached mod, where only the market template is changed by including the following BuildRestrictions:

<BuildRestrictions>
    <Category>Market</Category>
    <Distance>
      <FromClass>CivilCentre</FromClass>
      <MaxDistance>50</MaxDistance>
    </Distance>
  </BuildRestrictions>

it originates the following warning when placing the market:

JavaScript warning:simulation/components/BuildRestrictions.js line 302 reference to undefined property this.template.Distance.MinDistance

If, instead, we use <MinDistance>50</MinDistance> no warning is issued. Except for the warning, the simulation seems to run as expected on either way.

Don't know if this is related to #3529 .

[PASilva]

example mod

[elexis]

Oh, are you kidding me, this is the bug Grugnas has discovered in march in ​Phab:D276, that I asked him to fix separately few days ago. Since it's a one-liner, going to commit that now.

MinDistance is optional de jure, but the typo in the code tries to read from it when it intended to read from MaxDistance.

Thanks for the ticket, that was missing (considering that the patch went nowhere).

[elexis]

In 19997:

Fix copy&paste typo in the BuildRestrictions introduced by rP17398.

Fixes #4728
Refs #3081, D276
Patch By: Grugnas

[elexis]

Our templates are also correct and complete, because none use the MaxDistance. (If someone wants to improve it further, adding a test to catch this bug would have been the trve thing to do.)