Opened 6 years ago

Last modified 5 years ago

#5124 new enhancement

[PATCH] Improved Shadow Filter

Reported by: aeonios Owned by:
Priority: Nice to Have Milestone: Backlog
Component: Core engine Keywords:
Cc: Patch: Phab:D1486

Description

I replaced the PCF box filter with an 8 sample poisson disk filter. It should produce noticeably smoother shadows.

Attachments (1)

shadow_filter.patch (3.8 KB ) - added by aeonios 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Stan, 6 years ago

Cc: Vladislavbelov added

Hey aeonios,

Thanks for working on this :) If you are not aware all patches should now be uploaded to code.wildfiregames.com in order to be reviewed :)

Look at the wiki for more information.

Thanks for the patch. Do you have any before/after screenshots ?

Last edited 6 years ago by Stan (previous) (diff)

comment:2 by aeonios, 6 years ago

Alright I'm set up on phabricator now and uploaded this patch. I probably need to be set up to be included in auto-build though.

No screenshots yet. Technical difficulties. :P Will make some soon though.

comment:3 by Stan, 6 years ago

Patch: D1450

comment:4 by Stan, 6 years ago

Patch: D1450Phab:D1450

comment:5 by aeonios, 6 years ago

Fixed an error that occurs with some drivers if you don't specify .r for the result of shadow2D.

by aeonios, 6 years ago

Attachment: shadow_filter.patch added

comment:6 by s0600204, 6 years ago

Milestone: Alpha 23Alpha 24

Hi, we're in feature freeze right now, and this looks to be non-critical. Thus, I'm bumping this back to Alpha 24.

If you feel this is incorrect, and that this change must be included in Alpha 23, please provide your reasoning.

Thank you for your contribution to 0 A.D.!

comment:7 by Imarok, 5 years ago

Component: UI & SimulationCore engine

Move tickets to their correct component.

comment:8 by Stan, 5 years ago

Milestone: Alpha 24Backlog
Patch: Phab:D1450Phab:D1486

Backlogging due to lack of progress. I updated the Phab diff as it was merged with another one.

comment:9 by Stan, 5 years ago

Cc: Vladislavbelov removed
Owner: aeonios removed
Status: assignednew
Note: See TracTickets for help on using tickets.