Units actually attacking an allied storehouse

[elexis]

In this r22484 replay at minute 23:35, bbs units attacked my storehouse that had just been captured by territory few moments ago (including health reduction), at the very top / north of the map.

So this might or might not be different from #3484.

[Freagarach]

Recent replay.

[Freagarach]

(Replay is from r23587.)

The problem is that an order to attack was given without allowing capture, thus the attacking entity will use melee, against an enemy structure. When the structure was captured by the ally it starts losing CP. In the check whether the attacking unit CanAttack the structure there is no check whether it can continue the current attack (i.e. one could pass the attack type currently used) but just whether it could, using all types possible, attack the entity. And it can, because there are enemy CP in the CP-array. Hence continueing the attack, although with melee.

Steps to reproduce:

• Have an ally and an enemy.
• Give the order to melee attack the building of an enemy.
• Use wololo to capture that building using your ally, make sure it will decay.
• Observe your unit attacking and damaging the structure of your ally.

[elexis]

Good job, reproducible with a23 too, sounds like it's there since the introduction of Capturing.

[Freagarach]

Thanks :)

Probably seen here as well ​https://trac.wildfiregames.com/ticket/3484#comment:13.

[Freagarach]

In r25242: Fix entities being able to attack allied structures in rare cases.

Caused by not checking the attack type while performing an attack.

Closes: #5511
Differential revision: D3840
References #3484

(Which was reverted in r25246.)

[Freagarach]

In 25264:

Fix entities able to attack allied structures in rare cases (take 2).

Caused by not checking the attack type whilst performing an attack.

Fixes: #5511
Differential revision: D3845
Refs. #3484