First turn (turn 0) not executed in visual replays.

[Freagarach]

Commands given in turn 0 are not executed in visual-replay mode. Attached one can find two replays, the only difference being that the first replay has the cheats commanded at turn 0 and the second replay has the cheats commanded at turn 1. Replays are SVN 22574.

When moving a non-interacting command (e.g. reveal map) from turn 0 to turn 1 the hash does not change. But when moving e.g. the metacheat from turn 0 to turn 1 the hash does change. Moving the latter from turn 1 to turn 2 does not change the hash as well.

[Freagarach]

Replay 1.

[Freagarach]

Replay 2.

[Freagarach]

(See also #5185.)

[wraitii]

In 24280:

Fix visual-replays not processing turn 0 commands.

Use FinishedOwnCommands, which is intented to plan commands for the N+2 turn, but can be used to run commands immediately by the replay manager, and unlike FinishedUpdate is called before the first update.

Reported by: Freagarach

Fixes #5546

Differential Revision: ​https://code.wildfiregames.com/D3067

[wraitii]

In 24764:

Revert rP24280, causing false OOS in visual replays.

rP24280 fixed #5546, but it seems to cause some rare OOS in visual replays, as reported in #5909. The culprit is likely that hashes aren't computed at quite the same moment and onDestroy changes things.

Reverting for now before A24.

Reported by: Angen

Refs #5546.
Fixes #5909

[wraitii]

Reopening following revert, need to give a better look at the code it seems.

[Stan]

Unlikely to get done for A26

[Freagarach]

Pushing back.