Opened 3 years ago
Closed 3 years ago
#6081 closed enhancement (fixed)
Clean Garrison-related code.
Reported by: | Freagarach | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 25 |
Component: | Simulation | Keywords: | |
Cc: | Patch: |
Description (last modified by )
There has been a significant effort in cleaning garrisoning-related code, yet more needs to be done.
As discussed on IRC today, the ticket is created to not forget when the person currently working on it disappears suddenly.
A list of possible things:
Ungarrison using cmpGarrisonable instead on cmpGarrisonHolder (refs. Phab:D3280).Phab:D3628Don't listen toPhab:D3627OnGlobalEntityRenamed
messages when the only use case is Skirmish Replacements (one can use a new message for those).
Change History (18)
comment:1 by , 3 years ago
Patch: | → Phab:D3627,Phab:D3628 |
---|
comment:2 by , 3 years ago
Keywords: | simple removed |
---|---|
Patch: | Phab:D3627,Phab:D3628 → Phab:D3627 Phab:D3628 |
comment:3 by , 3 years ago
comment:5 by , 3 years ago
Patch: | Phab:D3627 Phab:D3628 → Phab:D3627 Phab:D3628 Phab:D3648 |
---|---|
Priority: | Nice to Have → Should Have |
comment:6 by , 3 years ago
Description: | modified (diff) |
---|
comment:8 by , 3 years ago
Description: | modified (diff) |
---|
comment:11 by , 3 years ago
comment:15 by , 3 years ago
In r25123:
Technically seperate Turrets from GarrisonHolder.
While they often look alike, their behaviour is totally different. This split has some implications:
- There are now separate auras for garrisoning and turrets.
- Entities can now have both turret points and garrison slots, independent of eachother.
In general previous behaviour is maintained as much as possible.
Differential revision: D3150
Comments by: @Nescio, @wraitii
Tested by: @v32itas
comment:16 by , 3 years ago
Patch: | Phab:D3627 Phab:D3628 Phab:D3648 |
---|
comment:18 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Seems clean enough for now. Feel free to reopen if appropriate.
Again discussed today on IRC.
UnitAI
shouldn't probably care about garrisoning.Garrisonable
setsUnitAI
IDLE
.UnitAI
just check for being able to move.