Redundant options dialog popup without making any changes

[Langbart]

to reproduce

• start a normal match, go to options
• make no changes and try to close the options
• dialog pops up asking You have unsaved changes, do you want to close this window?

bisect

• [27192]

related

• related ticket #6205 and commit [25802]
  • setting same Priority:

[Stan]

Dupe of #5020?

[Stan]

Maybe #6808 ?

[Langbart]

• divide comments between bisect/related

[Langbart]

Replying to Stan:

Dupe of #5020?

Replying to Stan:

Maybe #6808 ?

They don't seem to be related, the options page was closed in A26 without a popup if the user didn't make any changes, since [27192] the save popup dialog is triggered again. Just a regression.

[Stan]

The ticket at 6808 states that the popup is triggered because some options cannot be saved and yet are still enabled.

[wraitii]

In 27730:

Fix 'Options' asking for confirmation without changes during a game.

Since rP27192, opening the 'Options' menu in-game will show that there are pending changes, even if the user has done nothing.
Unfortunately the cinematic logic to hide silhouettes, which comes from rP19797, is broken following those changes. We use the configuration to hide them, which results in us, indeed, changing the configuration.

There isn't really a good short term fix. This change only attemps to reset the setting if we changed it for a cinematic, which fixes the issue, but has drawbacks.
Ideally, we would use a superior config level, but we need to be careful about exposing that to JS.

Reported by: langbart

Fixes #6821

Differential Revision: ​https://code.wildfiregames.com/D5040